You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2023/11/27 00:27:12 UTC

[I] Cleanup `unit_test` in `array_expression.rs` [arrow-datafusion]

jayzhan211 opened a new issue, #8324:
URL: https://github.com/apache/arrow-datafusion/issues/8324

   The goal is that there is no rust test in this file anymore.
   
   _Originally posted by @alamb in https://github.com/apache/arrow-datafusion/pull/8313#discussion_r1405386301_
   
   File an issue to list the pending test to avoid duplicate work
   - [ ] make_array
   - [ ] array_element
   - [ ] array_pop_back
   - [ ] array_slice
   - [ ] array_append
   - [ ] array_prepend
   - [ ] array_concat
   - [ ] array_position
   - [ ] array_to_string
   - [ ] cardinality
   - [ ] array_length
   - [ ] array_dims
   - [ ] Port other function to common::utils  or just remove it
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port tests in `array_expression.rs` to `sqllogictest` [arrow-datafusion]

Posted by "Veeupup (via GitHub)" <gi...@apache.org>.

Veeupup commented on issue #8324:
URL: https://github.com/apache/arrow-datafusion/issues/8324#issuecomment-1827787843

   : )
   I find that almost all test cases have been added to the `sqllogictest`, so I just remove some duplicate test codes then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port tests in `array_expression.rs` to `sqllogictest` [arrow-datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.

jayzhan211 commented on issue #8324:
URL: https://github.com/apache/arrow-datafusion/issues/8324#issuecomment-1827770012

   > hi @jayzhan211, I can help with `make_array` `array_element` `array_pop_back`
   
   Sure! Go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port tests in `array_expression.rs` to `sqllogictest` [arrow-datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.

jayzhan211 commented on issue #8324:
URL: https://github.com/apache/arrow-datafusion/issues/8324#issuecomment-1827805895

   > : ) I find that almost all test cases have been added to the `sqllogictest`, so I just remove some duplicate test codes then
   
   Close this issue with only delete, cools


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port tests in `array_expression.rs` to `sqllogictest` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb closed issue #8324: Port tests in `array_expression.rs` to `sqllogictest`
URL: https://github.com/apache/arrow-datafusion/issues/8324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port tests in `array_expression.rs` to `sqllogictest` [arrow-datafusion]

Posted by "Veeupup (via GitHub)" <gi...@apache.org>.

Veeupup commented on issue #8324:
URL: https://github.com/apache/arrow-datafusion/issues/8324#issuecomment-1827758151

   hi @jayzhan211, I can help with `make_array` `array_element` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org