You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/17 20:47:00 UTC
[jira] [Commented] (AMBARI-24797) Support regex based metric
inclusion in KafkaTimelineMetricsReporter
[ https://issues.apache.org/jira/browse/AMBARI-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654165#comment-16654165 ]
ASF GitHub Bot commented on AMBARI-24797:
-----------------------------------------
avijayanhwx opened a new pull request #8: [AMBARI-24797] Support regex based metric inclusion in KafkaTimelineM…
URL: https://github.com/apache/ambari-metrics/pull/8
…etricsReporter.
## What changes were proposed in this pull request?
The request is to to add an additional config property external.kafka.metrics.include.regex to include metrics based on regex patterns. This property can take multiple comma separated regex expressions.
**Implementation Logic**
- By default, a metric will be included.
- If the metric starts with any of the prefixes in the exclude.prefix property, it is a candidate for discarding.
- However, for an "excluded" metric, if the metric starts with any of the prefixes in include.prefix or matches any pattern in include.regex, it will NOT be discarded.
## How was this patch tested?
Manual and unit testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Support regex based metric inclusion in KafkaTimelineMetricsReporter
> --------------------------------------------------------------------
>
> Key: AMBARI-24797
> URL: https://issues.apache.org/jira/browse/AMBARI-24797
> Project: Ambari
> Issue Type: Task
> Components: ambari-metrics
> Affects Versions: 2.8.0
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
>
> The request is to to add an additional config property *external.kafka.metrics.include.regex* to include metrics based on regex patterns. This property can take multiple comma separated regex expressions.
> Implementation Logic
> * By default, a metric will be included.
> * If the metric starts with any of the prefixes in the exclude.prefix property, it is a candidate for discarding.
> * However, for an "excluded" metric, if the metric starts with any of the prefixes in include.prefix or matches any pattern in include.regex, it will NOT be discarded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)