[GitHub] [kyuubi] link3280 commented on a diff in pull request #5134: [KYUUBI #4806][FLINK] Support time-out incremental result fetch for Flink engine

["link3280 (via GitHub)" <gi...@apache.org>]

link3280 commented on code in PR #5134:
URL: https://github.com/apache/kyuubi/pull/5134#discussion_r1296603108


##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperation.scala:
##########
@@ -98,25 +105,43 @@ abstract class FlinkOperation(session: Session) extends AbstractOperation(sessio
     assertState(OperationState.FINISHED)
     setHasResultSet(true)
     order match {
-      case FETCH_NEXT => resultSet.getData.fetchNext()
+      case FETCH_NEXT =>

Review Comment:
   > Is it changed to doing nothing for FETCH_NEXT ?
    
   Yes. Now `resultSet.getData.fetchNext()` is invoked lazily for Flink, when the fetched batch is fully consumed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org