You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Patrick Mueller (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 13:41:39 UTC
[jira] [Created] (CB-364) remove calls to alert()
remove calls to alert()
-----------------------
Key: CB-364
URL: https://issues.apache.org/jira/browse/CB-364
Project: Apache Callback
Issue Type: Bug
Components: CordovaJS
Reporter: Patrick Mueller
Assignee: Filip Maj
I've run into some cases of alert() usage in the cordova-js code. I think this is inappropriate, since we are using the cordova-js code in other environments than the browser, like the test harness. I end up seeing errors thrown on "alert() not defined" and such, which is masking the actual error from me.
Instead, we should define an alert()-y function somewhere - like cordova.alert(). This function can sniff if alert() is available, and if not, console.log() or the equivalent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-364) remove calls to alert()
Posted by "Filip Maj (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-364.
--------------------------
Resolution: Fixed
Fix Version/s: 1.6.0
Fixed in [396b9f|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=396b9faf3fe0319e5933129ec9f94fc1db5c49a0].
> remove calls to alert()
> -----------------------
>
> Key: CB-364
> URL: https://issues.apache.org/jira/browse/CB-364
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.6.0
>
>
> I've run into some cases of alert() usage in the cordova-js code. I think this is inappropriate, since we are using the cordova-js code in other environments than the browser, like the test harness. I end up seeing errors thrown on "alert() not defined" and such, which is masking the actual error from me.
> Instead, we should define an alert()-y function somewhere - like cordova.alert(). This function can sniff if alert() is available, and if not, console.log() or the equivalent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-364) remove calls to alert()
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235329#comment-13235329 ]
Filip Maj commented on CB-364:
------------------------------
I recommend putting this into the utils module.
> remove calls to alert()
> -----------------------
>
> Key: CB-364
> URL: https://issues.apache.org/jira/browse/CB-364
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
>
> I've run into some cases of alert() usage in the cordova-js code. I think this is inappropriate, since we are using the cordova-js code in other environments than the browser, like the test harness. I end up seeing errors thrown on "alert() not defined" and such, which is masking the actual error from me.
> Instead, we should define an alert()-y function somewhere - like cordova.alert(). This function can sniff if alert() is available, and if not, console.log() or the equivalent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-364) remove calls to alert()
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238021#comment-13238021 ]
Filip Maj commented on CB-364:
------------------------------
Actually fixed in [c10b80|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=c10b80eaf886a704fb144019bd869ea8962777bd].
> remove calls to alert()
> -----------------------
>
> Key: CB-364
> URL: https://issues.apache.org/jira/browse/CB-364
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.6.0
>
>
> I've run into some cases of alert() usage in the cordova-js code. I think this is inappropriate, since we are using the cordova-js code in other environments than the browser, like the test harness. I end up seeing errors thrown on "alert() not defined" and such, which is masking the actual error from me.
> Instead, we should define an alert()-y function somewhere - like cordova.alert(). This function can sniff if alert() is available, and if not, console.log() or the equivalent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira