You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/03/06 13:23:01 UTC
Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/
-----------------------------------------------------------
Review request for cloudstack, Nitin Mehta and Koushik Das.
Description
-------
CLOUDSTACK-1453: support restore for VM created from ISO
Previously this was not there. Fixed with small changes
This addresses bug CLOUDSTACK-1453.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
server/src/com/cloud/vm/UserVmManagerImpl.java ca9c13f
Diff: https://reviews.apache.org/r/9779/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On April 1, 2013, 7:41 a.m., Koushik Das wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3884
> > <https://reviews.apache.org/r/9779/diff/1/?file=267170#file267170line3884>
> >
> > Handling of iso case is not clear. Are you expecting the iso id in the newTemplateId parameter?
Now we have common API parameter id that takes either template ID or ISO ID. So in the restoreVMInternal method "newTemplateId" can be either template/ISO id, we handle it accordingly in the code.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review18578
-----------------------------------------------------------
On May 24, 2013, 5:52 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 5:52 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
> server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review18578
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java
<https://reviews.apache.org/r/9779/#comment38959>
What it means to restore from new iso? Do we need a new iso parameter?
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9779/#comment38963>
Handling of iso case is not clear. Are you expecting the iso id in the newTemplateId parameter?
- Koushik Das
On March 6, 2013, 12:23 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 12:23 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java ca9c13f
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review20991
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On May 24, 2013, 10:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 10:19 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
> server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/#review20990
-----------------------------------------------------------
Commit a34e577d1be5a25d7eb884147212ab51786b55e2 in branch refs/heads/master from Koushik Das <ko...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a34e577 ]
CLOUDSTACK-1453: support restore for VM created from ISO
This is to support restore a vm to a new/currently_attached ISO.
In the restorevm API we have an optional parameter templateId to restore the vm to the new template/ISO ID.
- ASF Subversion and Git Services
On May 24, 2013, 10:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9779/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 10:19 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and Koushik Das.
>
>
> Description
> -------
>
> CLOUDSTACK-1453: support restore for VM created from ISO
> Previously this was not there. Fixed with small changes
>
>
> This addresses bug CLOUDSTACK-1453.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
> server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
> server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
>
> Diff: https://reviews.apache.org/r/9779/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/
-----------------------------------------------------------
(Updated May 24, 2013, 10:19 a.m.)
Review request for cloudstack, Nitin Mehta and Koushik Das.
Changes
-------
updated patch with additional parameter as "templateid"(an optional template Id to restore vm from the new template. This can be an ISO id in case of restore vm deployed using ISO)
Description
-------
CLOUDSTACK-1453: support restore for VM created from ISO
Previously this was not there. Fixed with small changes
This addresses bug CLOUDSTACK-1453.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
Diff: https://reviews.apache.org/r/9779/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9779/
-----------------------------------------------------------
(Updated May 24, 2013, 5:52 a.m.)
Review request for cloudstack, Nitin Mehta and Koushik Das.
Changes
-------
I have changed the additional parameter templateid to "id" that can take either new template/ISO id and restore vm functionality works accordingly based on the vm deployment(either from template or ISO).
Description
-------
CLOUDSTACK-1453: support restore for VM created from ISO
Previously this was not there. Fixed with small changes
This addresses bug CLOUDSTACK-1453.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97
server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a
server/test/com/cloud/vm/UserVmManagerTest.java 6a97114
Diff: https://reviews.apache.org/r/9779/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala