You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/31 12:47:48 UTC

[GitHub] zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB

zentol commented on issue #6976: [FLINK-7155][metrics] Add new metrics reporter to InfluxDB
URL: https://github.com/apache/flink/pull/6976#issuecomment-459331867
 
 
   @knaufk That's a bug in 1.7.0-1.7.1, see [FLINK-11251](https://issues.apache.org/jira/browse/FLINK-11251).
   
   @1u0 The mocks in this PR render in unacceptable. We continuously run into into maintenance issues with mocks and thus avoid mocks wherever possible. The newly added checks for implementation details (did it call X method Y times) aren't helping in this regard; we can now quite literally not change the implementation without having to touch the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services