You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2024/03/06 09:39:39 UTC
[PR] chore(traits): deprecate registry [camel-k]
squakez opened a new pull request, #5222:
URL: https://github.com/apache/camel-k/pull/5222
<!-- Description -->
This PR aims to remove the support of the registry feature. The feature depends on the CLI exclusively therefore creates asymmetrical condition against any other Integration deployment procedures. Another reason why we want to eventually remove the feature is security: it directly connects to the container registry from user CLI, by accessing at operator configuration secrets. Beside that, it seems the feature requires the presence of "Spectrum" publishing mode which may be deprecated as well in future Camel K releases.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
chore(traits): deprecate registry
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(traits): deprecate registry [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5222:
URL: https://github.com/apache/camel-k/pull/5222#discussion_r1514156672
##########
pkg/apis/camel/v1/trait/registry.go:
##########
@@ -17,6 +17,8 @@ limitations under the License.
package trait
+// WARNING: The Tracing trait is **deprecated** and will removed in future release versions.
Review Comment:
Yeah, a regeneration is undergoing. In any case, we have a nightly process taking care to fix any generation mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(traits): deprecate registry [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #5222:
URL: https://github.com/apache/camel-k/pull/5222#discussion_r1514152176
##########
pkg/apis/camel/v1/trait/registry.go:
##########
@@ -17,6 +17,8 @@ limitations under the License.
package trait
+// WARNING: The Tracing trait is **deprecated** and will removed in future release versions.
Review Comment:
I guess you meant `Registry` instead of `Tracing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(traits): deprecate registry [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5222:
URL: https://github.com/apache/camel-k/pull/5222#issuecomment-1980881459
Beside security check (addressed already in `main`) and #5197 this should be okey. @lburgazzoli any objection to have this merged by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(traits): deprecate registry [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5222:
URL: https://github.com/apache/camel-k/pull/5222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org