You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/30 19:28:14 UTC

[GitHub] [spark] tgravescs commented on issue #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages

tgravescs commented on issue #24497: [SPARK-27630][CORE] Properly handle task end events from completed stages
URL: https://github.com/apache/spark/pull/24497#issuecomment-497454720
 
 
   Just skimming through, would it make sense to make a local case class that is StageAttempt to replace  (stageId, stageAttemptId) and rename some of the maps to be stageAttempt.... rather than stageId? More for readability than anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org