You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Chad Whipkey (JIRA)" <ji...@apache.org> on 2008/05/07 23:01:57 UTC
[jira] Created: (PIG-234) fix synchronization around staleCount in
DataCollector
fix synchronization around staleCount in DataCollector
------------------------------------------------------
Key: PIG-234
URL: https://issues.apache.org/jira/browse/PIG-234
Project: Pig
Issue Type: Bug
Components: impl
Reporter: Chad Whipkey
Priority: Minor
DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-234) fix synchronization around staleCount
in DataCollector
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595119#action_12595119 ]
Pi Song commented on PIG-234:
-----------------------------
Good eyes!!! Another bug from auto-boxing!!!
However:-
1. Currently we only run local execution engine in single-threaded mode so this buggy synchronization code doesn't cause any problem.
2. We are removing all of those spec classes as we are moving to the new pipeline design. Please have a look at PigType trunk. We need more people like you to help!!!
> fix synchronization around staleCount in DataCollector
> ------------------------------------------------------
>
> Key: PIG-234
> URL: https://issues.apache.org/jira/browse/PIG-234
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Chad Whipkey
> Priority: Minor
> Attachments: Change_synchronization_on_DataCollector.patch
>
>
> DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-234) fix synchronization around staleCount
in DataCollector
Posted by "Chad Whipkey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595411#action_12595411 ]
Chad Whipkey commented on PIG-234:
----------------------------------
Okay, if you are not going to be using this code then I think it's okay to close this bug. I will look at the PigType trunk in the future before making submissions. Thanks!
> fix synchronization around staleCount in DataCollector
> ------------------------------------------------------
>
> Key: PIG-234
> URL: https://issues.apache.org/jira/browse/PIG-234
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Chad Whipkey
> Priority: Minor
> Attachments: Change_synchronization_on_DataCollector.patch
>
>
> DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-234) fix synchronization around staleCount in
DataCollector
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-234.
--------------------------------
Resolution: Fixed
This code will no longer be used after execution pipeline rework is completed
> fix synchronization around staleCount in DataCollector
> ------------------------------------------------------
>
> Key: PIG-234
> URL: https://issues.apache.org/jira/browse/PIG-234
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Chad Whipkey
> Priority: Minor
> Attachments: Change_synchronization_on_DataCollector.patch
>
>
> DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-234) fix synchronization around staleCount in
DataCollector
Posted by "Chad Whipkey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chad Whipkey updated PIG-234:
-----------------------------
Attachment: Change_synchronization_on_DataCollector.patch
Please code review. This is my first patch ever so let me know if I should do things differently.
> fix synchronization around staleCount in DataCollector
> ------------------------------------------------------
>
> Key: PIG-234
> URL: https://issues.apache.org/jira/browse/PIG-234
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Chad Whipkey
> Priority: Minor
> Attachments: Change_synchronization_on_DataCollector.patch
>
>
> DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.