You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "VGalaxies (via GitHub)" <gi...@apache.org> on 2023/12/22 10:22:28 UTC
[PR] fix: add double quotes to avoid the impact of spaces on grep for scripts of validating release [incubator-hugegraph-doc]
VGalaxies opened a new pull request, #310:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/310
As title, if double quotes are not added, an error will occur during grep:
```text
grep: License|BSD-4-Clause|\bBCL\b|JSR-275|Amazon: No such file or directory
grep: Software: No such file or directory
grep: License|\bRSAL\b|\bQPL\b|\bSSPL|\bCPOL|\bNPL1|Creative: No such file or directory
grep: Commons: No such file or directory
grep: Non-Commercial: No such file or directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: double quotes to avoid spaces in grep for validating release [incubator-hugegraph-doc]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #310:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: add double quotes to avoid the impact of spaces on grep for scripts of validating release [incubator-hugegraph-doc]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #310:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/310#discussion_r1435593274
##########
dist/validate-release.sh:
##########
@@ -211,8 +211,8 @@ bin/stop-hugegraph.sh || exit
popd || exit
# clear source packages
-rm -rf ./*src*
-ls -lh
+#rm -rf ./*src*
+#ls -lh
Review Comment:
as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix: add double quotes to avoid the impact of spaces on grep for scripts of validating release [incubator-hugegraph-doc]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #310:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/310#discussion_r1435594243
##########
dist/validate-release.sh:
##########
@@ -211,8 +211,8 @@ bin/stop-hugegraph.sh || exit
popd || exit
# clear source packages
-rm -rf ./*src*
-ls -lh
+#rm -rf ./*src*
+#ls -lh
Review Comment:
I previously modified the traversal semantics of step 7, skipping the detection of source packages. Therefore, even if the intermediate artifacts from the previous steps are not deleted, it does not affect the detection process.
The intermediate artifacts are retained for ease of manual checking in subsequent steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org