You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by cs...@apache.org on 2011/01/21 12:09:43 UTC
svn commit: r1061741 -
/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
Author: cschneider
Date: Fri Jan 21 11:09:42 2011
New Revision: 1061741
URL: http://svn.apache.org/viewvc?rev=1061741&view=rev
Log:
CAMEL-3572 set exception on exchange instead of only logging it
Modified:
camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java?rev=1061741&r1=1061740&r2=1061741&view=diff
==============================================================================
--- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java (original)
+++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java Fri Jan 21 11:09:42 2011
@@ -28,10 +28,8 @@ import org.apache.camel.Exchange;
import org.apache.camel.FailedToCreateConsumerException;
import org.apache.camel.Processor;
import org.apache.camel.component.cxf.CxfConstants;
-import org.apache.camel.component.cxf.cxfbean.CxfBeanBinding;
import org.apache.camel.component.cxf.cxfbean.DefaultCxfBeanBinding;
import org.apache.camel.component.cxf.util.CxfHeaderHelper;
-import org.apache.camel.component.cxf.util.CxfMessageHelper;
import org.apache.camel.spi.HeaderFilterStrategy;
import org.apache.camel.util.ObjectHelper;
import org.apache.camel.util.ServiceHelper;
@@ -178,7 +176,7 @@ public class CamelDestination extends Ab
try {
incoming(exchange);
} catch (Throwable ex) {
- getLogger().log(Level.WARNING, "Failed to process incoming message: ", ex);
+ exchange.setException(ex);
}
}
}
Re: svn commit: r1061741 - /camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
Posted by Claus Ibsen <cl...@gmail.com>.
Would be nice if we could add unit tests to ensure against regressions
and what we change actually fix what we think it does.
On Fri, Jan 21, 2011 at 12:09 PM, <cs...@apache.org> wrote:
> Author: cschneider
> Date: Fri Jan 21 11:09:42 2011
> New Revision: 1061741
>
> URL: http://svn.apache.org/viewvc?rev=1061741&view=rev
> Log:
> CAMEL-3572 set exception on exchange instead of only logging it
>
> Modified:
> camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
>
> Modified: camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java
> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java?rev=1061741&r1=1061740&r2=1061741&view=diff
> ==============================================================================
> --- camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java (original)
> +++ camel/trunk/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/transport/CamelDestination.java Fri Jan 21 11:09:42 2011
> @@ -28,10 +28,8 @@ import org.apache.camel.Exchange;
> import org.apache.camel.FailedToCreateConsumerException;
> import org.apache.camel.Processor;
> import org.apache.camel.component.cxf.CxfConstants;
> -import org.apache.camel.component.cxf.cxfbean.CxfBeanBinding;
> import org.apache.camel.component.cxf.cxfbean.DefaultCxfBeanBinding;
> import org.apache.camel.component.cxf.util.CxfHeaderHelper;
> -import org.apache.camel.component.cxf.util.CxfMessageHelper;
> import org.apache.camel.spi.HeaderFilterStrategy;
> import org.apache.camel.util.ObjectHelper;
> import org.apache.camel.util.ServiceHelper;
> @@ -178,7 +176,7 @@ public class CamelDestination extends Ab
> try {
> incoming(exchange);
> } catch (Throwable ex) {
> - getLogger().log(Level.WARNING, "Failed to process incoming message: ", ex);
> + exchange.setException(ex);
> }
> }
> }
>
>
>
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/