You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by sunnypig <gi...@git.apache.org> on 2017/08/03 07:38:35 UTC

[GitHub] thrift pull request #1324: THRIFT-4275

GitHub user sunnypig opened a pull request:

    https://github.com/apache/thrift/pull/1324

    THRIFT-4275

    add support for zope.interface only (excluding support for twisted) in python compiler

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LoIdo/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1324
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1324: THRIFT-4275

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1324


---

[GitHub] thrift issue #1324: THRIFT-4275

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1324
  
    @sunnypig just a reminder one thing was missed and needs to be updated - see my last comment, at the very least updating the command registration so the option appears in compiler help is mandatory - also recommend you rebase on master to get a clean build from CI.


---

[GitHub] thrift issue #1324: THRIFT-4275

Posted by sunnypig <gi...@git.apache.org>.

Github user sunnypig commented on the issue:

    https://github.com/apache/thrift/pull/1324
  
    Sorry for my belated rely.  I have just updated the registration.  However, I have no idea on how to add a proper unit test,  since I can't find any test code for the option of "py:twisted" which perhaps can be taken for a reference.


---

[GitHub] thrift issue #1324: THRIFT-4275

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1324
  
    That's okay - the twisted tests can be found in ``test/py.twisted`` for reference.


---