[GitHub] [airflow] uranusjr commented on a change in pull request #20781: Fix airflow dag trigger cli

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#discussion_r780957893



##########
File path: tests/api/client/test_local_client.py
##########
@@ -76,6 +76,7 @@ def test_trigger_dag(self, mock):
                 conf=None,
                 external_trigger=True,
                 dag_hash=ANY,
+                data_interval=ANY,

Review comment:
       This should be checkable, can you try to not use `ANY` here (and the one below)?

##########
File path: airflow/api/common/trigger_dag.py
##########
@@ -88,6 +88,9 @@ def _trigger_dag(
             conf=run_conf,
             external_trigger=True,
             dag_hash=dag_bag.dags_hash.get(dag_id),
+            data_interval=_dag.timetable.infer_manual_data_interval(
+                run_after=timezone.coerce_datetime(execution_date)

Review comment:
       `execution_date` is never Noen and already aware at this point, so `pendulum.instance()` is probably a better call.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org