You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/05/03 13:13:05 UTC

[GitHub] spark pull request: Improve build configuration � �

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/590#issuecomment-42102419
  
    This PR appears to have many changes in it, even beyond the four listed in the description? I agree with @pwendell that it is useful to separate and deal with them individually. I say that because I personally support the change for SPARK-1693 and would like to see it in, but this PR does not contain all of the changes needed for it, and neither does the lone commit you reference. So I think it has to be redone as a new PR anyway.
    
    I wonder if it would be clearer to remove the several generic JIRAs and PRs that have been opened, and re-submit them as individual, separable, labeled changes. You would at least be helping me since I'm also interested in the build and want to follow these ideas too. SPARK-1693 already exists of course, and one your JIRAs can be re-specified for @pwendell 's 1 and 3. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---