You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by qi...@apache.org on 2018/04/21 10:01:58 UTC

carbondata git commit: [CARBONDATA-2357] Add column name and index mapping in Lucene datamap writer

Repository: carbondata
Updated Branches:
  refs/heads/master 12c164958 -> 6bef57b8b


[CARBONDATA-2357] Add column name and index mapping in Lucene datamap writer

This closes #2184


Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/6bef57b8
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/6bef57b8
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/6bef57b8

Branch: refs/heads/master
Commit: 6bef57b8bc833cc4ef7d8de8c744603d36a9dfec
Parents: 12c1649
Author: Jacky Li <ja...@qq.com>
Authored: Wed Apr 18 19:41:36 2018 +0800
Committer: QiangCai <qi...@qq.com>
Committed: Sat Apr 21 18:00:22 2018 +0800

----------------------------------------------------------------------
 .../carbondata/datamap/lucene/LuceneDataMapWriter.java   | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/carbondata/blob/6bef57b8/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
----------------------------------------------------------------------
diff --git a/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java b/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
index 83454b3..6cc89d6 100644
--- a/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
+++ b/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
@@ -196,6 +196,7 @@ public class LuceneDataMapWriter extends DataMapWriter {
       ramDir.close();
       return;
     }
+
     int pageSize = pages[0].getPageSize();
     for (int rowId = 0; rowId < pageSize; rowId++) {
       // create a new document
@@ -222,12 +223,10 @@ public class LuceneDataMapWriter extends DataMapWriter {
         //doc.add(new NumericDocValuesField(ROWID_NAME,rowId));
       }
 
-      // add other fields
-      for (int colIdx = 0; colIdx < columnsCount; colIdx++) {
-        if (indexedCarbonColumns.contains(pages[colIdx].getColumnSpec().getFieldName())) {
-          if (!pages[colIdx].getNullBits().get(rowId)) {
-            addField(doc, pages[colIdx], rowId, Field.Store.NO);
-          }
+      // add indexed columns value into the document
+      for (ColumnPage page : pages) {
+        if (!page.getNullBits().get(rowId)) {
+          addField(doc, page, rowId, Field.Store.NO);
         }
       }