You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/02/07 01:36:43 UTC
[kudu-CR] docs: improvements to transaction semantics
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9235
Change subject: docs: improvements to transaction semantics
......................................................................
docs: improvements to transaction semantics
Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
---
M docs/transaction_semantics.adoc
1 file changed, 16 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9235/1
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] docs: improvements to transaction semantics
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@59
PS1, Line 59: with different levels of consistency or correctness guarantees. Scans can perform time-travel reads, i.e.
nit: is this over the col limit? (seems like it, but i might be wrong as I forget if we have one for docs or what it is)
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@181
PS1, Line 181: `READ_LATEST`:: This is the default read mode. The server takes a snapshot of
: the MVCC state and proceeds with the read immediately. Reads in this mode only yield
: 'Read Committed' isolation.
are you leaving the new mode out on purpose?
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@205
PS1, Line 205: Note
don't we have a special "note" marker, or am I mistaken?
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@222
PS1, Line 222: Writes
ahah, well caught :)
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 01:00:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
docs: improvements to transaction semantics
Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Reviewed-on: http://gerrit.cloudera.org:8080/9235
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Kudu Jenkins
---
M docs/transaction_semantics.adoc
1 file changed, 21 insertions(+), 8 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc@214
PS2, Line 214: selection API has no effect on the consistency guarantees, which will hold no matter
: which replica is selected.
: ====
> nit move this inside the note above? also maybe rephrase to:
Done
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 19:55:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to transaction semantics
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 1: Code-Review+1
Which version of Kudu does this apply?
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:46:20 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9235
to look at the new patch set (#3).
Change subject: docs: improvements to transaction semantics
......................................................................
docs: improvements to transaction semantics
Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
---
M docs/transaction_semantics.adoc
1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9235/3
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@59
PS1, Line 59: with different levels of consistency or correctness guarantees. Scans can perform time-travel reads, i.e.
> nit: is this over the col limit? (seems like it, but i might be wrong as I
Done
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@181
PS1, Line 181: `READ_LATEST`:: This is the default read mode. The server takes a snapshot of
: the MVCC state and proceeds with the read immediately. Reads in this mode only yield
: 'Read Committed' isolation.
> are you leaving the new mode out on purpose?
Yeah, I am planning to do another patch to add it. This patch is only updating existing ones.
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@205
PS1, Line 205: Note
> don't we have a special "note" marker, or am I mistaken?
Done
http://gerrit.cloudera.org:8080/#/c/9235/1/docs/transaction_semantics.adoc@222
PS1, Line 222: Writes
> ahah, well caught :)
:)
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 07:43:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to transaction semantics
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 20:36:12 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to transaction semantics
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc
File docs/transaction_semantics.adoc:
http://gerrit.cloudera.org:8080/#/c/9235/2/docs/transaction_semantics.adoc@214
PS2, Line 214: However this API is considered as a means to control locality, never to be used for
: correctness. Each scan mode should hold the corresponding consistency guarantees,
: no matter which replica is selected.
nit move this inside the note above? also maybe rephrase to:
Kudu also provides replica selection API for users to choose at which replica the scan should be performed:
Java Client:: Call `KuduScannerBuilder#replicaSelection(...)`
{cpp} Client:: Call `KuduScanner::SetSelection(...)`
This API is a means to control locality and, in some cases, latency. The replica selection API has no effect on the consistency guarantees, which will hold no matter which replica is selected.
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Feb 2018 18:42:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 )
Change subject: docs: improvements to transaction semantics
......................................................................
Patch Set 1:
> Which version of Kudu does this apply?
The latest release version, 1.6.0.
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:37:45 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to transaction semantics
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9235
to look at the new patch set (#2).
Change subject: docs: improvements to transaction semantics
......................................................................
docs: improvements to transaction semantics
Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
---
M docs/transaction_semantics.adoc
1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/9235/2
--
To view, visit http://gerrit.cloudera.org:8080/9235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23a2751923a4214f52e6cdb233f7e3aeee207da2
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins