[GitHub] [arrow] mapleFU commented on a diff in pull request #35825: GH-32723: [C++][Parquet] Add option to use LARGE* variants of binary types

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1223915090


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -219,6 +219,7 @@ class FileReaderImpl : public FileReader {
     ctx->iterator_factory = SomeRowGroupsFactory(row_groups);
     ctx->filter_leaves = true;
     ctx->included_leaves = included_leaves;
+    ctx->use_large_binary_variants = reader_properties_.use_large_binary_variants();

Review Comment:
   This is ok, but would:
   
   ```c++
   Status FileReaderImpl::GetColumn(int i, FileColumnIteratorFactory iterator_factory,
                                    std::unique_ptr<ColumnReader>* out)
   ```
   
   Would this function lack the `ctx->use_large_binary_variants`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org