[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2179: [api] improve config options

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2179:
URL: https://github.com/apache/incubator-seatunnel/pull/2179#discussion_r927470151


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/ReadonlyConfig.java:
##########
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.configuration;
+
+import static org.apache.seatunnel.api.configuration.util.ConfigUtil.convertToJsonString;
+import static org.apache.seatunnel.api.configuration.util.ConfigUtil.convertValue;
+import static org.apache.seatunnel.api.configuration.util.ConfigUtil.flatteningMap;
+import static org.apache.seatunnel.api.configuration.util.ConfigUtil.treeMap;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+import org.apache.seatunnel.shade.com.typesafe.config.ConfigRenderOptions;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+public class ReadonlyConfig {
+
+    private static final ObjectMapper JACKSON_MAPPER = new ObjectMapper();
+
+    /**
+     * Stores the concrete key/value pairs of this configuration object.
+     */
+    protected final Map<String, Object> confData;
+
+    private ReadonlyConfig(Map<String, Object> confData) {
+        this.confData = confData;
+    }
+
+    public static ReadonlyConfig fromMap(Map<String, Object> map) {
+        return new ReadonlyConfig(treeMap(map));
+    }
+
+    public static ReadonlyConfig fromConfig(Config config) {
+        try {
+            return fromMap(JACKSON_MAPPER.readValue(
+                config.root().render(ConfigRenderOptions.concise()),

Review Comment:
   Here the `typesafe config` is converted to a json string and parsed into the required map using jackson



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org