[GitHub] [echarts] plainheart commented on a change in pull request #16347: fix(tooltip): fix the page will be frozen if multiple tooltips are provided.

[GitBox <gi...@apache.org>]

plainheart commented on a change in pull request #16347:
URL: https://github.com/apache/echarts/pull/16347#discussion_r780674582



##########
File path: src/model/Global.ts
##########
@@ -431,6 +433,18 @@ echarts.use([${seriesImportName}]);`);
                         return;
                     }
 
+                    // Before multiple tooltips get supported,
+                    // we do this check to avoid unexpected exception.
+                    if (mainType === 'tooltip') {
+                        if (tooltipExists) {
+                            if (__DEV__) {
+                                warn('Currently only one tooltip component is allowed.');

Review comment:
       Here we should tweak slightly, or it will output the log as many times as **the count of tooltip option - 1**.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org