[GitHub] [spark] MaxGekk commented on a diff in pull request #40955: [SPARK-42843][SQL] Update the error class _LEGACY_ERROR_TEMP_2007 to REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #40955:
URL: https://github.com/apache/spark/pull/40955#discussion_r1182106079


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1009,6 +1009,11 @@
           "<value>."
         ]
       },
+      "REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT" : {
+        "message" : [
+          "Regex group count is <groupCount>, but the specified group index is <groupIndex>."

Review Comment:
   Not obvious the valid range for `groupIndex`. Could you write the message in the format:
   ```
   expects ..., but got ...
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1009,6 +1009,11 @@
           "<value>."
         ]
       },
+      "REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT" : {

Review Comment:
   Could you make it shorter, please. I think it is enough to just name the invalid parameter. For instance, `REGEX_GROUP_INDEX`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org