You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Justin Ross <ju...@gmail.com> on 2015/02/10 21:15:15 UTC
QPID-6347
https://issues.apache.org/jira/browse/QPID-6347
https://reviews.apache.org/r/30465/
This change from Irina cleans up some old options. It's reviewed and it
tests out for me.
One thing though: it appears to change a Java API. Is it one that we need
to maintain, or can we safely remove this option?
The other changes here to the old C++ client API are fine because that API
is long deprecated.
Justin
Re: QPID-6347
Posted by Justin Ross <ju...@gmail.com>.
That's all I need. Thanks!
On Wed, Feb 11, 2015 at 1:10 PM, Fraser Adams <fraser.adams@blueyonder.co.uk
> wrote:
> Hi Rob,
> I must admit that I've not been paying much attention to this thread.
>
> Is this just some stuff around queue_event_generation operation clean-up
> (that's what the Jira suggests)?
>
> I only ever put those things in the QMF stuff because they were in
> qpid-config, I never use them myself :-) basically I viewed qpid-config as
> the vaguely canonical QMF example, so I can't see an issue.
>
> Irina's patch looks fine to me, though I've only skimmed it.
>
> Frase
>
>
> On 10/02/15 20:54, Rob Godfrey wrote:
>
>> If I understand this correctly, this is a change to remove an option that
>> is no longer supported, and the Java change is just remove the option from
>> QMF tooling in the same way it is removed from Python tooling. Fraser can
>> correct me if I am wrong, but I don't think this is any sort of "API" that
>> we need to maintain.
>>
>> -- Rob
>>
>> On 10 February 2015 at 21:15, Justin Ross <ju...@gmail.com> wrote:
>>
>> https://issues.apache.org/jira/browse/QPID-6347
>>> https://reviews.apache.org/r/30465/
>>>
>>> This change from Irina cleans up some old options. It's reviewed and it
>>> tests out for me.
>>>
>>> One thing though: it appears to change a Java API. Is it one that we
>>> need
>>> to maintain, or can we safely remove this option?
>>>
>>> The other changes here to the old C++ client API are fine because that
>>> API
>>> is long deprecated.
>>>
>>> Justin
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>
Re: QPID-6347
Posted by Fraser Adams <fr...@blueyonder.co.uk>.
Hi Rob,
I must admit that I've not been paying much attention to this thread.
Is this just some stuff around queue_event_generation operation clean-up
(that's what the Jira suggests)?
I only ever put those things in the QMF stuff because they were in
qpid-config, I never use them myself :-) basically I viewed qpid-config
as the vaguely canonical QMF example, so I can't see an issue.
Irina's patch looks fine to me, though I've only skimmed it.
Frase
On 10/02/15 20:54, Rob Godfrey wrote:
> If I understand this correctly, this is a change to remove an option that
> is no longer supported, and the Java change is just remove the option from
> QMF tooling in the same way it is removed from Python tooling. Fraser can
> correct me if I am wrong, but I don't think this is any sort of "API" that
> we need to maintain.
>
> -- Rob
>
> On 10 February 2015 at 21:15, Justin Ross <ju...@gmail.com> wrote:
>
>> https://issues.apache.org/jira/browse/QPID-6347
>> https://reviews.apache.org/r/30465/
>>
>> This change from Irina cleans up some old options. It's reviewed and it
>> tests out for me.
>>
>> One thing though: it appears to change a Java API. Is it one that we need
>> to maintain, or can we safely remove this option?
>>
>> The other changes here to the old C++ client API are fine because that API
>> is long deprecated.
>>
>> Justin
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org
Re: QPID-6347
Posted by Rob Godfrey <ro...@gmail.com>.
If I understand this correctly, this is a change to remove an option that
is no longer supported, and the Java change is just remove the option from
QMF tooling in the same way it is removed from Python tooling. Fraser can
correct me if I am wrong, but I don't think this is any sort of "API" that
we need to maintain.
-- Rob
On 10 February 2015 at 21:15, Justin Ross <ju...@gmail.com> wrote:
> https://issues.apache.org/jira/browse/QPID-6347
> https://reviews.apache.org/r/30465/
>
> This change from Irina cleans up some old options. It's reviewed and it
> tests out for me.
>
> One thing though: it appears to change a Java API. Is it one that we need
> to maintain, or can we safely remove this option?
>
> The other changes here to the old C++ client API are fine because that API
> is long deprecated.
>
> Justin
>