[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1948: IGNITE-19262 Sql. Throw exception on explicit TX with DDL

["ygerzhedovich (via GitHub)" <gi...@apache.org>]

ygerzhedovich commented on code in PR #1948:
URL: https://github.com/apache/ignite-3/pull/1948#discussion_r1170937702


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -597,6 +597,19 @@ public void errors() {
             await(ars.closeAsync());
             assertThrowsWithCause(() -> await(ars.fetchNextPage()), CursorClosedException.class);
         }
+
+        // DDL is non-transactional.

Review Comment:
   I would like an additional test when we do a few operations in the transaction and just after it calls DDL in the same TX. Check that transaction is not rolled back or committed 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org