[jira] [Issue Comment Deleted] (CALCITE-2506) RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch

["pengzhiwei (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

pengzhiwei updated CALCITE-2506:
--------------------------------
    Comment: was deleted

(was: I fix this issue by compute the "digest" in the constructor of RexCall. I think the "digest" should be computed in the init time of RexNode as it can be used after that just like the "simplifyCoalesce" did.

One problem for this PR is that the  "computeDigest" may call twice in the constructor for RexOver which overwrite the "computeDigest" method and must be called after the "window" has been prepared. The PR is here [PR873|https://github.com/apache/calcite/pull/873].

Please have a check,thanks!)

> RexSimplify: coalesce(unaryPlus(nullInt), unaryPlus(vInt())) results in AssertionError: result mismatch
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2506
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2506
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>            Priority: Major
>              Labels: newbie
>
> {{coalesce(unaryPlus(nullInt), unaryPlus(vInt()))}} results in
> {noformat}java.lang.AssertionError: result mismatch: when applied to {?0.int0=-1}, COALESCE(+(null), +(?0.int0)) yielded -1, and +(null) yielded NULL
> 	at org.apache.calcite.rex.RexSimplify.verify(RexSimplify.java:1162)
> 	at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:175){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)