[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #328: Added support for Red Hat OS

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #328: Added support for Red Hat OS
URL: https://github.com/apache/fluo-muchos/pull/328#discussion_r390481230
 
 

 ##########
 File path: ansible/roles/common/tasks/main.yml
 ##########
 @@ -39,6 +52,16 @@
   retries: 10
   delay: 15
   until: yumresult is not failed
+- name: "enable SELinux (Red Hat)"
+  block:
+    - name: "check if container-selinux is installed"
+      shell: "rpm -q --quiet container-selinux"
+      register: container_selinux_installed
+      failed_when: container_selinux_installed.rc == 2
+    - name: "install container-selinux"
+      shell: "sudo yum -y install http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.107-1.el7_6.noarch.rpm"
 
 Review comment:
   If using RHEL7, it seems better to enable the extras subscription rather than pull this RPM from the CentOS repos at all. From https://fedoraproject.org/wiki/EPEL :
   
   ```
   on RHEL 7 it is recommended to also enable the optional, extras, and HA repositories since EPEL packages may depend on packages from these repositories:
      # subscription-manager repos --enable "rhel-*-optional-rpms" --enable "rhel-*-extras-rpms"  --enable "rhel-ha-for-rhel-*-server-rpms"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services