You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Burn Lewis (JIRA)" <ui...@incubator.apache.org> on 2007/10/06 00:14:51 UTC

[jira] Created: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
-------------------------------------------------------------------------------------------

                 Key: UIMA-591
                 URL: https://issues.apache.org/jira/browse/UIMA-591
             Project: UIMA
          Issue Type: Bug
          Components: Examples
            Reporter: Burn Lewis
            Priority: Minor


When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

Posted by "Michael Baessler (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585588#action_12585588 ] 

Michael Baessler commented on UIMA-591:
---------------------------------------

Is this issue tested and ready to close?

> In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
> -------------------------------------------------------------------------------------------
>
>                 Key: UIMA-591
>                 URL: https://issues.apache.org/jira/browse/UIMA-591
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>            Priority: Minor
>             Fix For: 2.2.2
>
>         Attachments: UIMA-591.patch
>
>
> When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

Posted by "Burn Lewis (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Burn Lewis closed UIMA-591.
---------------------------


Looks fine ... I've been running a similar variant for some time, although without the synchronized additions.  There are other timing issues we should test, e.g. a step is disabled after it has been returned as the next in a flow, but before it is used ... but that's a different issue.

> In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
> -------------------------------------------------------------------------------------------
>
>                 Key: UIMA-591
>                 URL: https://issues.apache.org/jira/browse/UIMA-591
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>            Priority: Minor
>             Fix For: 2.2.2
>
>         Attachments: UIMA-591.patch
>
>
> When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marshall Schor resolved UIMA-591.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.2
         Assignee: Burn Lewis

Applied the patch.  Also made (multi-threaded) references to the mSequence which holds the flow sequence, synchronized.  Assigning to Burn to test

> In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
> -------------------------------------------------------------------------------------------
>
>                 Key: UIMA-591
>                 URL: https://issues.apache.org/jira/browse/UIMA-591
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>            Priority: Minor
>             Fix For: 2.2.2
>
>         Attachments: UIMA-591.patch
>
>
> When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

Posted by "Burn Lewis (JIRA)" <ui...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/UIMA-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Burn Lewis updated UIMA-591:
----------------------------

    Attachment: UIMA-591.patch

> In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
> -------------------------------------------------------------------------------------------
>
>                 Key: UIMA-591
>                 URL: https://issues.apache.org/jira/browse/UIMA-591
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>            Reporter: Burn Lewis
>            Priority: Minor
>         Attachments: UIMA-591.patch
>
>
> When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (UIMA-591) In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect

Posted by "Burn Lewis (JIRA)" <ui...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/UIMA-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533128 ] 

Burn Lewis commented on UIMA-591:
---------------------------------

Clarification:  When a failed delegate is removed with removeAnalysisEngines any active Flows at or beyond this delegate will skip a delegate.  This includes the current Flow if continueOnFailure is true.

Current UIMA framework does NOT call removeAnalysisEngines so the bug is not exposed, yet.

> In uimaj-examples the AdvancedFixedFlowController method removeAnalysisEngines is incorrect
> -------------------------------------------------------------------------------------------
>
>                 Key: UIMA-591
>                 URL: https://issues.apache.org/jira/browse/UIMA-591
>             Project: UIMA
>          Issue Type: Bug
>          Components: Examples
>            Reporter: Burn Lewis
>            Priority: Minor
>         Attachments: UIMA-591.patch
>
>
> When an AE is removed from the flow and continueOnRetryFailure is true the CAS falsely skips the next delegate.  A patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.