You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2011/09/06 20:45:23 UTC

svn commit: r1165778 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

Author: danielsh
Date: Tue Sep  6 18:45:23 2011
New Revision: 1165778

URL: http://svn.apache.org/viewvc?rev=1165778&view=rev
Log:
On the fs-successor-ids branch:

Avoid calling into libsvn_fs from libsvn_fs_fs.  Add a comment.

* subversion/libsvn_fs_fs/fs_fs.c
  (write_final_rev): Use the private equivalent of a private API.
    Also, add a comment.

Modified:
    subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

Modified: subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c?rev=1165778&r1=1165777&r2=1165778&view=diff
==============================================================================
--- subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c Tue Sep  6 18:45:23 2011
@@ -5543,14 +5543,18 @@ write_final_rev(const svn_fs_id_t **new_
 
   noderev->id = new_id;
 
+  /* Maybe add a mapping to SUCCESSOR_IDS. */
   if (successor_ids && noderev->predecessor_id)
     {
-      svn_string_t *unparsed_pred = svn_fs_unparse_id(noderev->predecessor_id,
-                                                      pool);
-      svn_string_t *unparsed_succ = svn_fs_unparse_id(noderev->id, pool);
-      apr_array_header_t *successors = apr_hash_get(successor_ids,
-                                                    unparsed_pred->data,
-                                                    APR_HASH_KEY_STRING);
+      svn_string_t *unparsed_pred;
+      svn_string_t *unparsed_succ;
+      apr_array_header_t *successors;
+      
+      unparsed_pred = svn_fs_fs__id_unparse(noderev->predecessor_id, pool);
+      unparsed_succ = svn_fs_fs__id_unparse(noderev->id, pool);
+      successors = apr_hash_get(successor_ids, unparsed_pred->data,
+                                APR_HASH_KEY_STRING);
+
       if (successors)
         APR_ARRAY_PUSH(successors, const char *) = unparsed_succ->data;
       else