You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2010/08/14 09:04:32 UTC
[jira] Created: (DOXIA-405) The generated xhtml document has the
entire content on a single line
The generated xhtml document has the entire content on a single line
--------------------------------------------------------------------
Key: DOXIA-405
URL: http://jira.codehaus.org/browse/DOXIA-405
Project: Maven Doxia
Issue Type: Improvement
Components: Module - Xhtml
Affects Versions: 1.1.3
Environment: Maven Site Plugin 2.1.1
Windows XP Pro
Reporter: Dennis Lundberg
If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (DOXIA-405) The generated xhtml
document has the entire content on a single line
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282564#comment-282564 ]
Herve Boutemy edited comment on DOXIA-405 at 11/1/11 4:28 PM:
--------------------------------------------------------------
tried to implement it.
The feature is easy to do:
{noformat}
Index: src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
===================================================================
--- src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (revision 1196075)
+++ src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (working copy)
@@ -107,6 +107,12 @@
}
StringBuilder sb = new StringBuilder();
+
+ if ( t.isBlock() )
+ {
+ sb.append( EOL );
+ }
+
sb.append( LESS_THAN );
if ( nameSpace != null )
{noformat}
There are quite a few sink test methods to fix, add EOL ad trimming some results: easy too
But there is a hard part: identity tests are severely affected, since the newline adds some text before blocks
I'm stuck...
was (Author: hboutemy):
tried to implement it.
The feature is easy to do:
{noformat}
Index: src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
===================================================================
--- src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (revision 1196075)
+++ src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (working copy)
@@ -107,6 +107,12 @@
}
StringBuilder sb = new StringBuilder();
+
+ if ( t.isBlock() )
+ {
+ sb.append( EOL );
+ }
+
sb.append( LESS_THAN );
if ( nameSpace != null )
{noformat}
> The generated xhtml document has the entire content on a single line
> --------------------------------------------------------------------
>
> Key: DOXIA-405
> URL: https://jira.codehaus.org/browse/DOXIA-405
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Xhtml
> Affects Versions: 1.1.3
> Environment: Maven Site Plugin 2.1.1
> Windows XP Pro
> Reporter: Dennis Lundberg
>
> If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
> For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-405) The generated xhtml document has the
entire content on a single line
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282549#comment-282549 ]
Herve Boutemy commented on DOXIA-405:
-------------------------------------
ok, real pretty printing, with indentation, should be done outsite
But having some newlines is useful
> The generated xhtml document has the entire content on a single line
> --------------------------------------------------------------------
>
> Key: DOXIA-405
> URL: https://jira.codehaus.org/browse/DOXIA-405
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Xhtml
> Affects Versions: 1.1.3
> Environment: Maven Site Plugin 2.1.1
> Windows XP Pro
> Reporter: Dennis Lundberg
>
> If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
> For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-405) The generated xhtml document has the
entire content on a single line
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=232015#action_232015 ]
Lukas Theussl commented on DOXIA-405:
-------------------------------------
See http://maven.apache.org/doxia/faq.html#Why_XML_based_sinks_don_t_generate_nicely_formatted_documents
I think pretty printing should be done outside doxia, eg in the site plugin or site renderer.
> The generated xhtml document has the entire content on a single line
> --------------------------------------------------------------------
>
> Key: DOXIA-405
> URL: http://jira.codehaus.org/browse/DOXIA-405
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Xhtml
> Affects Versions: 1.1.3
> Environment: Maven Site Plugin 2.1.1
> Windows XP Pro
> Reporter: Dennis Lundberg
>
> If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
> For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIA-405) The generated xhtml document has the entire
content on a single line
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed DOXIA-405.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.4
Assignee: Herve Boutemy
done in [r1410919|http://svn.apache.org/viewvc?rev=1410919&view=rev]
I did a trick to make the identity test pass: the identity test is run without EOLs addition...
> The generated xhtml document has the entire content on a single line
> --------------------------------------------------------------------
>
> Key: DOXIA-405
> URL: https://jira.codehaus.org/browse/DOXIA-405
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Xhtml
> Affects Versions: 1.1.3
> Environment: Maven Site Plugin 2.1.1
> Windows XP Pro
> Reporter: Dennis Lundberg
> Assignee: Herve Boutemy
> Fix For: 1.4
>
>
> If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
> For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-405) The generated xhtml document has the
entire content on a single line
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIA-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282564#comment-282564 ]
Herve Boutemy commented on DOXIA-405:
-------------------------------------
tried to implement it.
The feature is easy to do:
{noformat}
Index: src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
===================================================================
--- src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (revision 1196075)
+++ src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java (working copy)
@@ -107,6 +107,12 @@
}
StringBuilder sb = new StringBuilder();
+
+ if ( t.isBlock() )
+ {
+ sb.append( EOL );
+ }
+
sb.append( LESS_THAN );
if ( nameSpace != null )
{noformat}
> The generated xhtml document has the entire content on a single line
> --------------------------------------------------------------------
>
> Key: DOXIA-405
> URL: https://jira.codehaus.org/browse/DOXIA-405
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Xhtml
> Affects Versions: 1.1.3
> Environment: Maven Site Plugin 2.1.1
> Windows XP Pro
> Reporter: Dennis Lundberg
>
> If you view the source for http://maven.apache.org/plugins/index.html, you will see that the entire content is on line 207 and is 35396 columns wide. Trying to debug such a page is near impossible.
> For very large documents is isn't even possible for some browsers to show the source with that many columns.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira