[GitHub] [lucene-solr] dsmiley opened a new pull request #969: SOLR-13855: DistributedZkUpdateProcessor needs to propagate finish()

[GitBox <gi...@apache.org>]

dsmiley opened a new pull request #969: SOLR-13855: DistributedZkUpdateProcessor needs to propagate finish()
URL: https://github.com/apache/lucene-solr/pull/969
 
 
   Passes tests.  There's a nocommit comment on wether a distributed scenario should not propagate the finish() call.  It was not in the past (checked via null "nodes" field), but I think it should always propagate because even if "nodes" is null processAdd might pass on through a particular document if it's local to the shard receiving the request.  @yonik WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org