[kudu] 02/03: hms: remove experimental tag from hms flags

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

abukor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit ecfc874319d0243b078a40cf849d6dca3a11bd3b
Author: Andrew Wong <aw...@apache.org>
AuthorDate: Wed Apr 24 18:35:01 2019 -0700

    hms: remove experimental tag from hms flags
    
    The HMS integration has been in our codebase for a while now. While the
    behavior of integration may change (a la KUDU-2799), the configuration
    options themselves aren't likely to do so. This patch tags the necessary
    configuration flags as "evolving" (the default) to facilitate their
    usage and testing of the integration.
    
    Change-Id: I4f862a805a370c250a712347d48965ed71fbd78e
    Reviewed-on: http://gerrit.cloudera.org:8080/13124
    Tested-by: Kudu Jenkins
    Reviewed-by: Hao Hao <ha...@cloudera.com>
    Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
 src/kudu/hms/hms_catalog.cc                      | 8 --------
 src/kudu/master/hms_notification_log_listener.cc | 2 --
 2 files changed, 10 deletions(-)

diff --git a/src/kudu/hms/hms_catalog.cc b/src/kudu/hms/hms_catalog.cc
index 9749582..ac211e8 100644
--- a/src/kudu/hms/hms_catalog.cc
+++ b/src/kudu/hms/hms_catalog.cc
@@ -60,7 +60,6 @@ DEFINE_string(hive_metastore_uris, "",
               "If not set, the Kudu master will not send Kudu table catalog updates to Hive. The "
               "configured value must match the Hive hive.metastore.uris configuration.");
 DEFINE_validator(hive_metastore_uris, &kudu::hms::HmsCatalog::ValidateUris);
-TAG_FLAG(hive_metastore_uris, experimental);
 
 // Note: the hive_metastore_sasl_enabled and keytab_file combination is validated in master.cc.
 DEFINE_bool(hive_metastore_sasl_enabled, false,
@@ -68,44 +67,37 @@ DEFINE_bool(hive_metastore_sasl_enabled, false,
             "(Kerberos) security. Must match the value of the "
             "hive.metastore.sasl.enabled option in the Hive Metastore configuration. "
             "When enabled, the --keytab_file flag must be provided.");
-TAG_FLAG(hive_metastore_sasl_enabled, experimental);
 
 DEFINE_string(hive_metastore_kerberos_principal, "hive",
               "The service principal of the Hive Metastore server. Must match "
               "the primary (user) portion of hive.metastore.kerberos.principal option "
               "in the Hive Metastore configuration.");
-TAG_FLAG(hive_metastore_kerberos_principal, experimental);
 
 DEFINE_int32(hive_metastore_retry_count, 1,
              "The number of times that HMS operations will retry after "
              "encountering retriable failures, such as network errors.");
 TAG_FLAG(hive_metastore_retry_count, advanced);
-TAG_FLAG(hive_metastore_retry_count, experimental);
 
 DEFINE_int32(hive_metastore_send_timeout_seconds, 60,
              "Configures the socket send timeout, in seconds, for Thrift "
              "connections to the Hive Metastore.");
 TAG_FLAG(hive_metastore_send_timeout_seconds, advanced);
-TAG_FLAG(hive_metastore_send_timeout_seconds, experimental);
 
 DEFINE_int32(hive_metastore_recv_timeout_seconds, 60,
              "Configures the socket receive timeout, in seconds, for Thrift "
              "connections to the Hive Metastore.");
 TAG_FLAG(hive_metastore_recv_timeout_seconds, advanced);
-TAG_FLAG(hive_metastore_recv_timeout_seconds, experimental);
 
 DEFINE_int32(hive_metastore_conn_timeout_seconds, 60,
              "Configures the socket connect timeout, in seconds, for Thrift "
              "connections to the Hive Metastore.");
 TAG_FLAG(hive_metastore_conn_timeout_seconds, advanced);
-TAG_FLAG(hive_metastore_conn_timeout_seconds, experimental);
 
 DEFINE_int32(hive_metastore_max_message_size_bytes, 100 * 1024 * 1024,
              "Maximum size of Hive Metastore objects that can be received by the "
              "HMS client in bytes. Should match the metastore.server.max.message.size "
              "configuration.");
 TAG_FLAG(hive_metastore_max_message_size_bytes, advanced);
-TAG_FLAG(hive_metastore_max_message_size_bytes, experimental);
 
 namespace kudu {
 namespace hms {
diff --git a/src/kudu/master/hms_notification_log_listener.cc b/src/kudu/master/hms_notification_log_listener.cc
index 64a8d14..929c404 100644
--- a/src/kudu/master/hms_notification_log_listener.cc
+++ b/src/kudu/master/hms_notification_log_listener.cc
@@ -50,14 +50,12 @@ DEFINE_uint32(hive_metastore_notification_log_poll_period_seconds, 15,
               "the Hive Metastore for catalog updates.");
 TAG_FLAG(hive_metastore_notification_log_poll_period_seconds, advanced);
 TAG_FLAG(hive_metastore_notification_log_poll_period_seconds, runtime);
-TAG_FLAG(hive_metastore_notification_log_poll_period_seconds, experimental);
 
 DEFINE_int32(hive_metastore_notification_log_batch_size, 100,
              "Number of notification log entries which are retrieved from the Hive Metastore "
              "per batch when polling.");
 TAG_FLAG(hive_metastore_notification_log_batch_size, advanced);
 TAG_FLAG(hive_metastore_notification_log_batch_size, runtime);
-TAG_FLAG(hive_metastore_notification_log_batch_size, experimental);
 
 DEFINE_uint32(hive_metastore_notification_log_poll_inject_latency_ms, 0,
               "Inject latency into the inner polling loop of the Hive Metastore"