You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2018/12/12 02:40:21 UTC

[tinkerpop] 07/08: OptOut a store test in RemoteGraph because we now test GraphSON

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit a9efe8d7ae7586e16836e53100d307c8c08f339a
Author: Stephen Mallette <sp...@genoprime.com>
AuthorDate: Tue Dec 11 20:06:33 2018 -0500

    OptOut a store test in RemoteGraph because we now test GraphSON
    
    Don't support BulkSet along 3.3.x so that test won't pass. CTR
---
 .../java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java | 4 ++++
 .../gremlin/process/traversal/step/sideEffect/StoreTest.java          | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java
index f19d5fa..70343a8 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/remote/RemoteGraph.java
@@ -95,6 +95,10 @@ import java.util.Iterator;
         test = "org.apache.tinkerpop.gremlin.process.traversal.TraversalInterruptionComputerTest",
         method = "*",
         reason = "The interruption model in the test can't guarantee interruption at the right time with RemoteGraph.")
+@Graph.OptOut(
+        test = "org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.StoreTest",
+        method = "g_withSideEffectXa_setX_V_both_name_storeXaX_capXaX",
+        reason = "This test returns BulkSet which isn't supported in GraphSON 3.0 until 3.4.0.")
 @Deprecated
 public class RemoteGraph implements Graph {
 
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/StoreTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/StoreTest.java
index 40b03ef..8f6759e 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/StoreTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/StoreTest.java
@@ -88,7 +88,6 @@ public abstract class StoreTest extends AbstractGremlinProcessTest {
         printTraversalForm(traversal);
         final Set<String> names = traversal.next();
         assertFalse(traversal.hasNext());
-        assertFalse(names instanceof BulkSet);
         assertEquals(6, names.size());
         assertTrue(names.contains("marko"));
         assertTrue(names.contains("vadas"));