[GitHub] [tvm] junrushao1994 commented on a diff in pull request #11298: [Meta Schedule] Fix testing issues for models with more than one inputs

[GitBox <gi...@apache.org>]

junrushao1994 commented on code in PR #11298:
URL: https://github.com/apache/tvm/pull/11298#discussion_r871874492


##########
python/tvm/meta_schedule/testing/custom_builder_runner.py:
##########
@@ -167,4 +167,4 @@ def run_module_via_rpc(
         rt_mod = session.load_module(filename)
         dev = session.device(dev_type=dev_type, dev_id=0)
         args = [ndarray.array(arg, dev) for arg in args]
-        return continuation(rt_mod, dev, *args)
+        return continuation(rt_mod, dev, args)

Review Comment:
   Note: the intention of the star here is to allow more flexible function signatures like:
   
   ```python
   def f_timer(mod, dev, a): ...
   def f_timer(mod, dev, a, b): ...
   def f_timer(mod, dev, a, b, c): ...
   def f_timer(mod, dev, a, b, c, d): ...
   ```
   
   but i guess there is no fundamental difference, so i have no strong opinion here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org