You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ksmou (via GitHub)" <gi...@apache.org> on 2023/06/17 17:16:40 UTC
[GitHub] [hudi] ksmou opened a new pull request, #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
ksmou opened a new pull request, #9004:
URL: https://github.com/apache/hudi/pull/9004
### Change Logs
Flink supports schedule the clustering in batch execution mode.
### Impact
None
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1595819764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378e52696092484636ee6d10b2bd9536d4955ad5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] ksmou commented on a diff in pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "ksmou (via GitHub)" <gi...@apache.org>.
ksmou commented on code in PR #9004:
URL: https://github.com/apache/hudi/pull/9004#discussion_r1233186739
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -452,15 +444,23 @@ private void handleEndInputEvent(WriteMetadataEvent event) {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
// sync Hive synchronously if it is enabled in batch mode.
syncHive();
- // schedules the compaction plan in batch execution mode
- if (tableState.scheduleCompaction) {
- // if async compaction is on, schedule the compaction
- CompactionUtil.scheduleCompaction(metaClient, writeClient, tableState.isDeltaTimeCompaction, true);
- }
+ // schedules the compaction or clustering if it is enabled in batch execution mode
+ scheduleCompactionOrClustering(true);
}
}
}
+ private void scheduleCompactionOrClustering(Boolean committed) {
+ // if compaction is on, schedule the compaction
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1595958807
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
}, {
"hash" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17943",
"triggerID" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378e52696092484636ee6d10b2bd9536d4955ad5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936)
* 8de3b52fc91e33fd636cbe3e33a308e98cf87792 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17943)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1596018868
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
}, {
"hash" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17943",
"triggerID" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8de3b52fc91e33fd636cbe3e33a308e98cf87792 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17943)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1595956588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
}, {
"hash" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8de3b52fc91e33fd636cbe3e33a308e98cf87792",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378e52696092484636ee6d10b2bd9536d4955ad5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936)
* 8de3b52fc91e33fd636cbe3e33a308e98cf87792 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9004:
URL: https://github.com/apache/hudi/pull/9004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1595821442
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378e52696092484636ee6d10b2bd9536d4955ad5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9004:
URL: https://github.com/apache/hudi/pull/9004#issuecomment-1595860369
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936",
"triggerID" : "378e52696092484636ee6d10b2bd9536d4955ad5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378e52696092484636ee6d10b2bd9536d4955ad5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17936)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9004:
URL: https://github.com/apache/hudi/pull/9004#discussion_r1233174013
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -452,15 +444,23 @@ private void handleEndInputEvent(WriteMetadataEvent event) {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
// sync Hive synchronously if it is enabled in batch mode.
syncHive();
- // schedules the compaction plan in batch execution mode
- if (tableState.scheduleCompaction) {
- // if async compaction is on, schedule the compaction
- CompactionUtil.scheduleCompaction(metaClient, writeClient, tableState.isDeltaTimeCompaction, true);
- }
+ // schedules the compaction or clustering if it is enabled in batch execution mode
+ scheduleCompactionOrClustering(true);
}
}
}
+ private void scheduleCompactionOrClustering(Boolean committed) {
+ // if compaction is on, schedule the compaction
Review Comment:
scheduleCompactionOrClustering -> scheduleTableServices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] ksmou commented on a diff in pull request #9004: [HUDI-6396]Flink supports schedule the clustering in batch execution mode and code refactor
Posted by "ksmou (via GitHub)" <gi...@apache.org>.
ksmou commented on code in PR #9004:
URL: https://github.com/apache/hudi/pull/9004#discussion_r1233186739
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -452,15 +444,23 @@ private void handleEndInputEvent(WriteMetadataEvent event) {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
// sync Hive synchronously if it is enabled in batch mode.
syncHive();
- // schedules the compaction plan in batch execution mode
- if (tableState.scheduleCompaction) {
- // if async compaction is on, schedule the compaction
- CompactionUtil.scheduleCompaction(metaClient, writeClient, tableState.isDeltaTimeCompaction, true);
- }
+ // schedules the compaction or clustering if it is enabled in batch execution mode
+ scheduleCompactionOrClustering(true);
}
}
}
+ private void scheduleCompactionOrClustering(Boolean committed) {
+ // if compaction is on, schedule the compaction
Review Comment:
+1
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -452,15 +444,23 @@ private void handleEndInputEvent(WriteMetadataEvent event) {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
// sync Hive synchronously if it is enabled in batch mode.
syncHive();
- // schedules the compaction plan in batch execution mode
- if (tableState.scheduleCompaction) {
- // if async compaction is on, schedule the compaction
- CompactionUtil.scheduleCompaction(metaClient, writeClient, tableState.isDeltaTimeCompaction, true);
- }
+ // schedules the compaction or clustering if it is enabled in batch execution mode
+ scheduleCompactionOrClustering(true);
}
}
}
+ private void scheduleCompactionOrClustering(Boolean committed) {
+ // if compaction is on, schedule the compaction
Review Comment:
has changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org