You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by mi...@apache.org on 2006/10/11 00:52:32 UTC

svn commit: r462625 - in /db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness: RunTest.java j9_foundation.java

Author: mikem
Date: Tue Oct 10 15:52:31 2006
New Revision: 462625

URL: http://svn.apache.org/viewvc?view=rev&rev=462625
Log:
DERBY-1785
contributed by Myrna van Lunteren
patch: DERBY-1785_102_20061007.diff

I've decided to do the same thing as for the trunk for the foundation setup; 
but do a crude skip for all junit tests when run through 
the harness against the other j9 versions. 


Modified:
    db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java
    db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java

Modified: db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java?view=diff&rev=462625&r1=462624&r2=462625
==============================================================================
--- db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java (original)
+++ db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java Tue Oct 10 15:52:31 2006
@@ -1249,6 +1249,15 @@
 		    usesystem = sp.getProperty("usesystem");
 		}
 
+		// junit tests do not run successfully with j9 - except for j9_foundation 
+		// see DERBY-1785
+		if ((jvmName.startsWith("j9")) && (!jvmName.equals("j9_foundation")) && testType.equals("junit"))
+		{
+		    skiptest = true;
+		    addSkiptestReason("Test skipped: cannot run junit test with j9 jvms because of security manager issue in the jvm");
+		}
+			
+
 		// Some tests will not run well in a suite with use process false 
 		// with some frameworks, so skip
 		if (!useprocess && !skiptest )

Modified: db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java
URL: http://svn.apache.org/viewvc/db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java?view=diff&rev=462625&r1=462624&r2=462625
==============================================================================
--- db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java (original)
+++ db/derby/code/branches/10.2/java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java Tue Oct 10 15:52:31 2006
@@ -128,9 +128,13 @@
     }
 	public String getDintro() { return "-D"; }
 
-	protected void setSecurityProps()
-	{
-		System.out.println("Note: J9 (foundation) tests do not run with security manager");		
-	}
+// Having the following method overload the one in jvm.java causes problems when running
+// the junit tests - they *do* successfully run with securityManager.
+// Foundation class tests actually run ok with security manager - except when useprocess
+// is false. This is caused by a bug in the jvm. See also DERBY-885 and DERBY-1785.
+//	protected void setSecurityProps()
+//	{
+//		System.out.println("Note: J9 (foundation) tests do not run with security manager");		
+//	}
 
 }