You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/02/29 02:13:55 UTC
[spark] branch branch-3.0 updated: [SPARK-30977][CORE][3.0] Make
ResourceProfile and ResourceProfileBuilder private
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 4cac4a5 [SPARK-30977][CORE][3.0] Make ResourceProfile and ResourceProfileBuilder private
4cac4a5 is described below
commit 4cac4a50e0bd81edc7a6a18674a64045c7c247bb
Author: Thomas Graves <tg...@nvidia.com>
AuthorDate: Fri Feb 28 18:12:20 2020 -0800
[SPARK-30977][CORE][3.0] Make ResourceProfile and ResourceProfileBuilder private
### What changes were proposed in this pull request?
Make the ResourceProfile and ResourceProfileBuilder apis private since the entire feature didn't make 3.0.
### Why are the changes needed?
to not expose to user to early.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
unit tests
Closes #27737 from tgravescs/SPARK-30977.
Authored-by: Thomas Graves <tg...@nvidia.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala | 5 ++++-
.../scala/org/apache/spark/resource/ResourceProfileBuilder.scala | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala b/core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
index 14019d2..f3c39d9 100644
--- a/core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
+++ b/core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
@@ -34,9 +34,12 @@ import org.apache.spark.internal.config.Python.PYSPARK_EXECUTOR_MEMORY
* specify executor and task requirements for an RDD that will get applied during a
* stage. This allows the user to change the resource requirements between stages.
* This is meant to be immutable so user can't change it after building.
+ *
+ * This api is currently private until the rest of the pieces are in place and then it
+ * will become public.
*/
@Evolving
-class ResourceProfile(
+private[spark] class ResourceProfile(
val executorResources: Map[String, ExecutorResourceRequest],
val taskResources: Map[String, TaskResourceRequest]) extends Serializable with Logging {
diff --git a/core/src/main/scala/org/apache/spark/resource/ResourceProfileBuilder.scala b/core/src/main/scala/org/apache/spark/resource/ResourceProfileBuilder.scala
index 0d55c17..db1c77d 100644
--- a/core/src/main/scala/org/apache/spark/resource/ResourceProfileBuilder.scala
+++ b/core/src/main/scala/org/apache/spark/resource/ResourceProfileBuilder.scala
@@ -29,9 +29,12 @@ import org.apache.spark.annotation.Evolving
* A ResourceProfile allows the user to specify executor and task requirements for an RDD
* that will get applied during a stage. This allows the user to change the resource
* requirements between stages.
+ *
+ * This api is currently private until the rest of the pieces are in place and then it
+ * will become public.
*/
@Evolving
-class ResourceProfileBuilder() {
+private[spark] class ResourceProfileBuilder() {
private val _taskResources = new ConcurrentHashMap[String, TaskResourceRequest]()
private val _executorResources = new ConcurrentHashMap[String, ExecutorResourceRequest]()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org