[GitHub] [arrow] nickhaddady commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function

[GitBox <gi...@apache.org>]

nickhaddady commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r806215678



##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
 target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
 target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
 
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
 
-# Build mexfcn MEX binary.
+# Build call MEX binary.
 matlab_add_mex(R2018a
-               NAME mexfcn
-               SRC ${mexfcn_sources}
+               NAME mexcall

Review comment:
       Will the name of shared library here end up being mexcall.so or mexcall.dll?  Since mex files are shared libraries, and they need to be unique on some platforms (namely linux) to avoid symbol collisions.  mexcall is still fairly generic.  
   
   I would consider something more obfuscated like mlarrowmexcall.so  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org