You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/12 04:18:23 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early
lhotari opened a new pull request, #17584:
URL: https://github.com/apache/pulsar/pull/17584
Fixes #17583
### Motivation
Pulsar CI is broken since "Pulsar CI checks completed" runs too early
### Modifications
- remove "if: always()" since it caused the job to run also when something failed
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#issuecomment-1243269946
Available disk space before building docker image:
```
/dev/root 85161M 41518M 43627M 49% /
```
Available disk space after building docker image:
```
/dev/root 85161M 83949M 1197M 99% /
```
I wonder when the build started consuming so much disk space? @tisonkun could it be related to the Trino changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#issuecomment-1243520168
> @lhotari something is still wrong. Unit test Broker 2 timed out: https://github.com/apache/pulsar/runs/8299450001?check_suite_focus=true Checks completed job has been skipped: https://github.com/apache/pulsar/runs/8300402413?check_suite_focus=true
>
> But I'm still able to merge your pull
there's a follow up in #17586 to address this problem. This solution is inspired by @tisonkun 's solution in kvrocks (https://github.com/apache/pulsar/pull/17584#discussion_r967974810).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#issuecomment-1243281546
@lhotari I don't find the possibility by #17062. It does some rename and location change works, while no docker image layer change. You may go through the assembly and dockerfile changes for double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#discussion_r967974810
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -844,7 +844,6 @@ jobs:
'system-tests',
'macos-build'
]
- if: always()
Review Comment:
I ever wrote another script for running always but check the result of needs to determinate which cleanups can be trigger.
See also https://github.com/apache/incubator-kvrocks/blob/2402dfec05c582235dfb195bb1d4210584e59848/.github/workflows/kvrocks.yaml#L220-L233.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#discussion_r967975451
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -844,7 +844,6 @@ jobs:
'system-tests',
'macos-build'
]
- if: always()
Review Comment:
thanks, nice example. I didn't know about that `${{ needs.build-and-test.result }}` trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#issuecomment-1243342613
@lhotari something is still wrong.
Unit test Broker 2 timed out: https://github.com/apache/pulsar/runs/8299450001?check_suite_focus=true
Checks completed job has been skipped: https://github.com/apache/pulsar/runs/8300402413?check_suite_focus=true
But I'm still able to merge your pull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17584:
URL: https://github.com/apache/pulsar/pull/17584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17584: [fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17584:
URL: https://github.com/apache/pulsar/pull/17584#issuecomment-1243483196
Hi @lhotari @nicoloboschi according to docker image changes, this patch may be relevant https://github.com/apache/pulsar/pull/17129.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org