Re: [PR] KAFKA-20245: DLQ records exceeding max delivery count. [3/N] [kafka]

["apoorvmittal10 (via GitHub)" <gi...@apache.org>]

apoorvmittal10 commented on code in PR #22080:
URL: https://github.com/apache/kafka/pull/22080#discussion_r3183796096


##########
server/src/main/java/org/apache/kafka/server/share/fetch/InFlightState.java:
##########
@@ -161,7 +165,7 @@ public InFlightState tryUpdateState(RecordState newState, DeliveryCountOps ops,
             }
 
             if (newState == RecordState.AVAILABLE && ops != DeliveryCountOps.DECREASE && deliveryCount >= maxDeliveryCount) {
-                newState = RecordState.ARCHIVED;
+                newState = shareGroupDlqEnableSupplier.get() ? RecordState.ARCHIVING : RecordState.ARCHIVED;

Review Comment:
   Sounds good, probably will discuss again when we add the readState handling.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org