[jira] [Commented] (STREAMS-235) TwitterFollowingProvider

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STREAMS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393157#comment-14393157 ] 

ASF GitHub Bot commented on STREAMS-235:
----------------------------------------

Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/202#discussion_r27685931
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterFollowActivityConverter.java ---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.twitter.converter;
    +
    +import com.google.common.collect.Lists;
    +import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.data.ActivityConverter;
    +import org.apache.streams.exceptions.ActivityConversionException;
    +import org.apache.streams.pojo.json.Activity;
    +import org.apache.streams.pojo.json.ActivityObject;
    +import org.apache.streams.pojo.json.Provider;
    +import org.apache.streams.twitter.pojo.Follow;
    +import org.apache.streams.twitter.converter.util.TwitterActivityUtil;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class TwitterFollowActivityConverter implements ActivityConverter<Follow>, Serializable {
    +
    +    public TwitterFollowActivityConverter() {
    +    }
    +
    +    private static TwitterFollowActivityConverter instance = new TwitterFollowActivityConverter();
    +
    +    public static TwitterFollowActivityConverter getInstance() {
    +        return instance;
    +    }
    +
    +    public static Class requiredClass = Follow.class;
    +
    +    @Override
    +    public Class requiredClass() {
    +        return requiredClass;
    +    }
    +
    +    @Override
    +    public String serializationFormat() {
    +        return null;
    +    }
    +
    +    @Override
    +    public Follow fromActivity(Activity deserialized) throws ActivityConversionException {
    --- End diff --
    
    Is there a reason this isn't implemented? Seems like it'd be straight forward if the verb is a follow and actor and object are populated.


> TwitterFollowingProvider
> ------------------------
>
>                 Key: STREAMS-235
>                 URL: https://issues.apache.org/jira/browse/STREAMS-235
>             Project: Streams
>          Issue Type: New Feature
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>             Fix For: 0.2
>
>
> New provider - page through friends and/or followers endpoints to produce follow activities.  actor and object should have properties/extensions aligned to actor on post/share activities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)