You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/18 06:13:20 UTC
[kudu-CR] KUDU-1097 turn on 3-4-3 replica management scheme
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8862
Change subject: KUDU-1097 turn on 3-4-3 replica management scheme
......................................................................
KUDU-1097 turn on 3-4-3 replica management scheme
This patch enables 3-4-3 replica management scheme for tablets: now
the 3-4-3 scheme is used by default. To switch back to 3-2-3 scheme,
set --raft_prepare_replacement_before_eviction=false for both masters
and tablet servers.
Change-Id: I781d02fe455140ed3a4693438eece74f07700946
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8862/1
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-1097: turn on 3-4-3 replica management scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8862
to look at the new patch set (#4).
Change subject: KUDU-1097: turn on 3-4-3 replica management scheme
......................................................................
KUDU-1097: turn on 3-4-3 replica management scheme
This patch enables 3-4-3 replica management scheme for tablets: now
the 3-4-3 scheme is used by default. To switch back to 3-2-3 scheme,
set --raft_prepare_replacement_before_eviction=false for both masters
and tablet servers.
Change-Id: I781d02fe455140ed3a4693438eece74f07700946
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8862/4
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1097 turn on 3-4-3 replica management scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097 turn on 3-4-3 replica management scheme
......................................................................
Patch Set 2: Verified+1
All failures are due to unrelated clock issues:
Cannot initialize clock: Error reading clock. Clock considered unsynchronized
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 20 Dec 2017 22:39:42 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1097: turn on 3-4-3 replica management scheme
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097: turn on 3-4-3 replica management scheme
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 09 Jan 2018 01:12:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1097 turn on 3-4-3 replica management scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097 turn on 3-4-3 replica management scheme
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1097 turn on 3-4-3 replica management scheme
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097 turn on 3-4-3 replica management scheme
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8862/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8862/3//COMMIT_MSG@7
PS3, Line 7: KUDU-1097
nit: mind adding a period or colon after the JIRA id, for readability?
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 00:25:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: turn on 3-4-3 replica management scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097: turn on 3-4-3 replica management scheme
......................................................................
KUDU-1097: turn on 3-4-3 replica management scheme
This patch enables 3-4-3 replica management scheme for tablets: now
the 3-4-3 scheme is used by default. To switch back to 3-2-3 scheme,
set --raft_prepare_replacement_before_eviction=false for both masters
and tablet servers.
Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Reviewed-on: http://gerrit.cloudera.org:8080/8862
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1097: turn on 3-4-3 replica management scheme
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8862 )
Change subject: KUDU-1097: turn on 3-4-3 replica management scheme
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8862/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8862/3//COMMIT_MSG@7
PS3, Line 7: KUDU-1097
> nit: mind adding a period or colon after the JIRA id, for readability?
Done
--
To view, visit http://gerrit.cloudera.org:8080/8862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I781d02fe455140ed3a4693438eece74f07700946
Gerrit-Change-Number: 8862
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 02:22:34 +0000
Gerrit-HasComments: Yes