[GitHub] [druid] gianm edited a comment on pull request #10233: Add "offset" parameter to the Scan query.

[GitBox <gi...@apache.org>]

gianm edited a comment on pull request #10233:
URL: https://github.com/apache/druid/pull/10233#issuecomment-668173929


   Hmm, I just realized that this method of paginating is a bad idea if you're doing time ordering and lots of rows have the same timestamp. It uses a `java.util.PriorityQueue` internally, which isn't stable with regard to rows with the same timestamp. This is fine if you're only doing one query, but it means that offset-based pagination will not be stable either. More thought and test coverage is needed to make sure we handle this case properly.
   
   I've converted the patch to a draft.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org