[GitHub] [beam] pareshsarafmdb commented on a change in pull request #14927: [BEAM-12400] MongoDBIO support for update within documents

[GitBox <gi...@apache.org>]

pareshsarafmdb commented on a change in pull request #14927:
URL: https://github.com/apache/beam/pull/14927#discussion_r689446518



##########
File path: sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/UpdateField.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.mongodb;
+
+import java.io.Serializable;
+
+public class UpdateField implements Serializable {
+
+  private String updateOperator;
+
+  private String sourceField;
+
+  private String destField;
+
+  public UpdateField(String updateOperator, String sourceField, String destField) {
+    this.updateOperator = updateOperator;
+    this.sourceField = sourceField;
+    this.destField = destField;
+  }
+
+  /** for updating field by field. */
+  public static UpdateField of(String updateOperator, String sourceField, String destField) {
+    return new UpdateField(updateOperator, sourceField, destField);
+  }
+
+  /** for updating with entire input document. */
+  public static UpdateField of(String updateOperator, String destField) {
+    return new UpdateField(updateOperator, null, destField);

Review comment:
       This is used when we need to update full source document into destination document. (Not updating specific fields). Whenever we have to update specific fields we need to specify which field in the source has to be updated to which field in dest document. Do you think there can be a better way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org