[GitHub] [spark] nchammas commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options

[GitBox <gi...@apache.org>]

nchammas commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r375010678
 
 

 ##########
 File path: sql/gen-sql-markdown.py
 ##########
 @@ -218,9 +236,73 @@ def generate_sql_markdown(jvm, path):
             mdfile.write("<br/>\n\n")
 
 
+def generate_sql_configs_table(jvm, path):
+    """
+    Generates an HTML table at `path` that lists all public SQL
+    configuration options.
+    """
+    sql_configs = _list_sql_configs(jvm)
+    value_reference_pattern = re.compile(r"^<value of (\S*)>$")
+    # ConfigEntry(key=spark.buffer.size, defaultValue=65536, doc=, public=true)
+    config_entry_pattern = re.compile(
+        r"ConfigEntry\(key=(\S*), defaultValue=\S*, doc=\S*, public=\S*\)")
 
 Review comment:
   I wish we didn't have to do this kind of stuff here. Is there a way to do this on the Scala side inside of `listSQLConfigs()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org