You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Jason Lowe (JIRA)" <ji...@apache.org> on 2018/09/28 14:21:00 UTC
[jira] [Moved] (MAPREDUCE-7146) Review of RMCommunicator Class
[ https://issues.apache.org/jira/browse/MAPREDUCE-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Lowe moved YARN-8832 to MAPREDUCE-7146:
---------------------------------------------
Affects Version/s: (was: 3.2.0)
3.2.0
Component/s: (was: applications)
mr-am
Key: MAPREDUCE-7146 (was: YARN-8832)
Project: Hadoop Map/Reduce (was: Hadoop YARN)
> Review of RMCommunicator Class
> ------------------------------
>
> Key: MAPREDUCE-7146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7146
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mr-am
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: YARN-88321.patch
>
>
> Various improvements to the {{RMCommunicator}} class.
>
> * Use SLF4J parameterized logging
> * Use switch statement instead of {{if}}-{{else statements}}
> * Remove anti-pattern of "log and throw" (just throw)
> * Use a flag to stop thread instead of an interrupt (it may be interrupting the heartbeat code and not the thread loop)
> * The main thread loops performs loops on the heartbeat callback queue until the queue is empty. It's technically possible that other threads could constantly put new callbacks into the queue and therefore the main thread never progresses past the callbacks. Put a cap on the number of callbacks that will be processed in any iteration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org