You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/01 13:04:42 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

lhotari opened a new pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116


   ### Motivation
   
   org.apache.pulsar.broker.service.ReplicatorTest.testConfigChange is one of the most flaky tests. A solution was put in place that fixes retries for most ReplicatorTests by #9823  . Retries failed for testConfigChange with this kind of exception
   ```
   java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@68598b0a rejected
    from java.util.concurrent.ThreadPoolExecutor@691c61c7[Terminated, pool size = 0, active threads = 0, q
   ueued tasks = 0, completed tasks = 0]
           at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.jav
   a:2063)
           at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
           at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
           at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
           at org.apache.pulsar.broker.service.ReplicatorTest.testConfigChange(ReplicatorTest.java:133)
   ```
   The problem is that executor is shutdown in cleanup, but not initialized in the setup method.
   
   ### Modifications
   
   - fix test retries by initializing the executor in the setup method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli merged pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116#issuecomment-812102077


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116#issuecomment-812337141


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116#issuecomment-812499899


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116#issuecomment-812442154


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #10116: Reduce flakiness of ReplicatorTest.testConfigChange

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10116:
URL: https://github.com/apache/pulsar/pull/10116#issuecomment-812296691


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org