You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/16 10:06:54 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #6253: [Improvement][Vectorized] Lower/upper case tranfer function vertorized
xinghuayu007 opened a new pull request #6253:
URL: https://github.com/apache/incubator-doris/pull/6253
## Proposed changes
Currently, the function `lower()/upper()` can only handle one char at a time. A vectorized function has been implemented, it makes performance 2 times faster. Here is the performance test:
The length of char: 26, test 100 times
vectorized-function-cost: 99491 ns
normal-function-cost: 134766 ns
The length of char: 260, test 100 times
vectorized-function-cost: 179341 ns
normal-function-cost: 344995 ns
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #6253: [Improvement][Vectorized] Lower/upper case tranfer function vertorized
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #6253:
URL: https://github.com/apache/incubator-doris/pull/6253#issuecomment-881834833
This pr refers to Clickhouse's Function implementation.
So I think it's better to indicate the source.
Then explain whether you have done any optimization or some customized for Doris's case.
You can see ```bitmap_value.h``` 's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo edited a comment on pull request #6253: [Improvement][Vectorized] Lower/upper case tranfer function vertorized
Posted by GitBox <gi...@apache.org>.
wangbo edited a comment on pull request #6253:
URL: https://github.com/apache/incubator-doris/pull/6253#issuecomment-881834833
This pr refers to Clickhouse's Function implementation.
So I think it's better to indicate the source.
Then explain whether you have done any your own optimization or some customized for Doris's case.
You can see ```bitmap_value.h``` 's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6253: [Improvement][Vectorized] Lower/upper case tranfer function vertorized
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6253:
URL: https://github.com/apache/incubator-doris/pull/6253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #6253: [Improvement][Vectorized] Lower/upper case tranfer function vertorized
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #6253:
URL: https://github.com/apache/incubator-doris/pull/6253#issuecomment-882333297
> This pr refers to Clickhouse's Function implementation.
> So I think it's better to indicate the source.
> Then explain whether you have done any your own optimization or some customized for Doris's case.
> You can see `bitmap_value.h` 's comment.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org