You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/21 17:27:36 UTC

[GitHub] codecov-io commented on issue #5687: [bugfix] Encode unicode error message response

codecov-io commented on issue #5687: [bugfix] Encode unicode error message response
URL: https://github.com/apache/incubator-superset/pull/5687#issuecomment-414755664
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=h1) Report
   > Merging [#5687](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0fbda33c68762a690ab6a19a03e5b6046fbdeccf?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5687/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5687      +/-   ##
   ==========================================
   - Coverage   63.49%   63.48%   -0.02%     
   ==========================================
     Files         360      360              
     Lines       22914    22926      +12     
     Branches     2551     2551              
   ==========================================
   + Hits        14550    14554       +4     
   - Misses       8349     8357       +8     
     Partials       15       15
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/5687/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `68% <100%> (ø)` | :arrow_up: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/5687/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `95% <0%> (-1.43%)` | :arrow_down: |
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5687/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.55% <0%> (-0.88%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5687/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.9% <0%> (-0.77%)` | :arrow_down: |
   | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5687/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.67% <0%> (+0.54%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=footer). Last update [0fbda33...ad4c25f](https://codecov.io/gh/apache/incubator-superset/pull/5687?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org