You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/04/23 04:27:19 UTC

[GitHub] spark pull request #21123: [SPARK-24045][SQL]Create base class for file data...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21123#discussion_r183274501
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -89,8 +91,13 @@ case class DataSource(
     
       case class SourceInfo(name: String, schema: StructType, partitionColumns: Seq[String])
     
    -  lazy val providingClass: Class[_] =
    -    DataSource.lookupDataSource(className, sparkSession.sessionState.conf)
    +  lazy val providingClass: Class[_] = {
    +    val cls = DataSource.lookupDataSource(className, sparkSession.sessionState.conf)
    +    cls.newInstance() match {
    +      case f: FileDataSourceV2 => f.fallBackFileFormat.getOrElse(cls)
    --- End diff --
    
    why do we need this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org