You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ecs-dev@jakarta.apache.org by sn...@apache.org on 2001/04/13 16:35:33 UTC

cvs commit: jakarta-ecs/src/java/org/apache/ecs/xhtml comment.java

snagy       01/04/13 07:35:33

  Modified:    src/java/org/apache/ecs ElementAttributes.java
                        StringElement.java
               src/java/org/apache/ecs/html Comment.java Script.java
               src/java/org/apache/ecs/rtf Bold.java BorderBottom.java
                        BorderLeft.java BorderRight.java BorderStyle.java
                        BorderTop.java Cell.java CellDef.java Centered.java
                        ColorGroup.java FontSize.java Indent.java
                        Justified.java Left.java RTFElement.java Right.java
                        Row.java
               src/java/org/apache/ecs/xhtml comment.java
  Log:
  Changing the scope of createStartTag and createEndTag had larger ramifications
  then I initially thought.  Change all of the classes that override this method
  so that they will compile.
  
  Revision  Changes    Path
  1.11      +3 -3      jakarta-ecs/src/java/org/apache/ecs/ElementAttributes.java
  
  Index: ElementAttributes.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/ElementAttributes.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- ElementAttributes.java	2000/04/10 17:46:56	1.10
  +++ ElementAttributes.java	2001/04/13 14:35:20	1.11
  @@ -62,7 +62,7 @@
   /**
       This class provides a common set of attributes set* methods for all classes.
       It is abstract to prevent direct instantiation.
  -    @version $Id: ElementAttributes.java,v 1.10 2000/04/10 17:46:56 jonbolt Exp $
  +    @version $Id: ElementAttributes.java,v 1.11 2001/04/13 14:35:20 snagy Exp $
       @author <a href="mailto:snagy@servletapi.com">Stephan Nagy</a>
       @author <a href="mailto:jon@clearink.com">Jon S. Stevens</a>
   */
  @@ -219,7 +219,7 @@
       /**
           Find out if we want to filter the elements attributes or not.
       */
  -    protected boolean getAttributeFilterState()
  +    public boolean getAttributeFilterState()
       {
           return(filter_attribute_state);
       }
  @@ -325,7 +325,7 @@
           This method overrides createStartTag() in Generic Element.
           It provides a way to print out the attributes of an element.
       */
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           StringBuffer out = new StringBuffer();
   
  
  
  
  1.4       +3 -3      jakarta-ecs/src/java/org/apache/ecs/StringElement.java
  
  Index: StringElement.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/StringElement.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- StringElement.java	2000/01/05 00:56:03	1.3
  +++ StringElement.java	2001/04/13 14:35:21	1.4
  @@ -59,7 +59,7 @@
       This class is used to create a String element in ECS. A StringElement 
       has no tags wrapped around it, it is an Element without tags.
       
  -    @version $Id: StringElement.java,v 1.3 2000/01/05 00:56:03 admin Exp $
  +    @version $Id: StringElement.java,v 1.4 2001/04/13 14:35:21 snagy Exp $
       @author <a href="mailto:snagy@servletapi.com">Stephan Nagy</a>
       @author <a href="mailto:jon@clearink.com">Jon S. Stevens</a>
   */
  @@ -166,11 +166,11 @@
           return(this);
       }
       
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return("");
       }
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return("");
       }
  
  
  
  1.7       +3 -3      jakarta-ecs/src/java/org/apache/ecs/html/Comment.java
  
  Index: Comment.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/html/Comment.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Comment.java	2000/01/18 08:53:44	1.6
  +++ Comment.java	2001/04/13 14:35:22	1.7
  @@ -65,7 +65,7 @@
   
   /**
       This class defines a comment &lt;-- VALUE --&gt; Element.
  -    @version $Id: Comment.java,v 1.6 2000/01/18 08:53:44 stephan Exp $
  +    @version $Id: Comment.java,v 1.7 2001/04/13 14:35:22 snagy Exp $
       @author <a href="mailto:snagy@servletapi.com">Stephan Nagy</a>
       @author <a href="mailto:jon@clearink.com">Jon S. Stevens</a>
   */
  @@ -153,7 +153,7 @@
           return(this);
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           setEndTagChar(' ');
           StringBuffer out = new StringBuffer();
  @@ -175,7 +175,7 @@
           return(out.toString());
       }
       
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer out = new StringBuffer();
           setStartTagChar(' ');
  
  
  
  1.4       +4 -4      jakarta-ecs/src/java/org/apache/ecs/html/Script.java
  
  Index: Script.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/html/Script.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Script.java	2000/01/05 01:17:41	1.3
  +++ Script.java	2001/04/13 14:35:22	1.4
  @@ -57,7 +57,7 @@
   /**
       This class creates a &lt;U&gt; tag.
   
  -    @version $Id: Script.java,v 1.3 2000/01/05 01:17:41 jonbolt Exp $
  +    @version $Id: Script.java,v 1.4 2001/04/13 14:35:22 snagy Exp $
       @author <a href="mailto:snagy@servletapi.com">Stephan Nagy</a>
       @author <a href="mailto:jon@clearink.com">Jon S. Stevens</a>
   */
  @@ -260,7 +260,7 @@
           browsers. We put in hard returns here because we want to make 
           sure that this code works even with PrettyPrint false.
       */
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           StringBuffer out = new StringBuffer();
           out.append(super.createStartTag());
  @@ -275,7 +275,7 @@
           browsers. We put in hard returns here because we want to make 
           sure that this code works even with PrettyPrint false.
       */    
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer out = new StringBuffer();
           out.append("\n");
  @@ -284,4 +284,4 @@
           out.append(super.createEndTag());
           return(out.toString());
       }
  -}
  \ No newline at end of file
  +}
  
  
  
  1.5       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/Bold.java
  
  Index: Bold.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Bold.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- Bold.java	2000/01/26 00:13:27	1.4
  +++ Bold.java	2001/04/13 14:35:24	1.5
  @@ -87,7 +87,7 @@
           addElement(element);
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
  @@ -95,7 +95,7 @@
       /**
           Create the end element for output.
       */
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer sb = new StringBuffer();
           sb.append(getElementType());
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/BorderBottom.java
  
  Index: BorderBottom.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/BorderBottom.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BorderBottom.java	2000/01/26 00:13:27	1.2
  +++ BorderBottom.java	2001/04/13 14:35:24	1.3
  @@ -71,12 +71,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/BorderLeft.java
  
  Index: BorderLeft.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/BorderLeft.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BorderLeft.java	2000/01/26 00:13:27	1.2
  +++ BorderLeft.java	2001/04/13 14:35:24	1.3
  @@ -71,12 +71,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/BorderRight.java
  
  Index: BorderRight.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/BorderRight.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BorderRight.java	2000/01/26 00:13:27	1.2
  +++ BorderRight.java	2001/04/13 14:35:24	1.3
  @@ -71,12 +71,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/BorderStyle.java
  
  Index: BorderStyle.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/BorderStyle.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BorderStyle.java	2000/01/26 00:13:27	1.2
  +++ BorderStyle.java	2001/04/13 14:35:25	1.3
  @@ -92,12 +92,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/BorderTop.java
  
  Index: BorderTop.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/BorderTop.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BorderTop.java	2000/01/26 00:13:27	1.2
  +++ BorderTop.java	2001/04/13 14:35:25	1.3
  @@ -71,12 +71,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +1 -1      jakarta-ecs/src/java/org/apache/ecs/rtf/Cell.java
  
  Index: Cell.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Cell.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Cell.java	2000/01/26 00:13:27	1.2
  +++ Cell.java	2001/04/13 14:35:25	1.3
  @@ -71,7 +71,7 @@
       /**
           Create the end element for output.
       */
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer sb = new StringBuffer();
           sb.append(" \\cell");
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/CellDef.java
  
  Index: CellDef.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/CellDef.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- CellDef.java	2000/01/26 00:13:27	1.2
  +++ CellDef.java	2001/04/13 14:35:25	1.3
  @@ -95,7 +95,7 @@
       /**
           Create the start element for output.
       */
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           StringBuffer sb = new StringBuffer();
           sb.append(getElementType());
  @@ -106,7 +106,7 @@
       /**
           Create the end element for output.
       */
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer sb = new StringBuffer();
           return(sb.toString());
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/Centered.java
  
  Index: Centered.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Centered.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Centered.java	2000/01/26 00:13:27	1.2
  +++ Centered.java	2001/04/13 14:35:25	1.3
  @@ -75,12 +75,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.5       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/ColorGroup.java
  
  Index: ColorGroup.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/ColorGroup.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- ColorGroup.java	2000/01/26 00:13:27	1.4
  +++ ColorGroup.java	2001/04/13 14:35:26	1.5
  @@ -75,12 +75,12 @@
           setElementType(r+g+b+";");
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return(getElementType());
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return("");
       }
  
  
  
  1.3       +1 -1      jakarta-ecs/src/java/org/apache/ecs/rtf/FontSize.java
  
  Index: FontSize.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/FontSize.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- FontSize.java	2000/01/26 00:13:28	1.2
  +++ FontSize.java	2001/04/13 14:35:26	1.3
  @@ -131,7 +131,7 @@
           return(this);
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return(getElementType());
       }
  
  
  
  1.3       +1 -1      jakarta-ecs/src/java/org/apache/ecs/rtf/Indent.java
  
  Index: Indent.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Indent.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Indent.java	2000/01/26 00:13:28	1.2
  +++ Indent.java	2001/04/13 14:35:26	1.3
  @@ -87,7 +87,7 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType()+_size;
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/Justified.java
  
  Index: Justified.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Justified.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Justified.java	2000/01/26 00:13:28	1.2
  +++ Justified.java	2001/04/13 14:35:26	1.3
  @@ -75,12 +75,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/Left.java
  
  Index: Left.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Left.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Left.java	2000/01/26 00:13:29	1.2
  +++ Left.java	2001/04/13 14:35:26	1.3
  @@ -75,12 +75,12 @@
           addElementToRegistry(element);
           return this;
       }
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.5       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/RTFElement.java
  
  Index: RTFElement.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/RTFElement.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- RTFElement.java	2000/01/26 00:13:29	1.4
  +++ RTFElement.java	2001/04/13 14:35:27	1.5
  @@ -67,7 +67,7 @@
           return getElement(key);
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           /* I should proabably store this within the class document, but
              RTF isn't as complex with tag types as other markups.
  @@ -79,7 +79,7 @@
           return(sb.toString());
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           /* I should proabably store this within the class document, but
              RTF isn't as complex with tag types as other markups.
  
  
  
  1.3       +2 -2      jakarta-ecs/src/java/org/apache/ecs/rtf/Right.java
  
  Index: Right.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Right.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Right.java	2000/01/26 00:13:29	1.2
  +++ Right.java	2001/04/13 14:35:27	1.3
  @@ -76,12 +76,12 @@
           return this;
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           return getElementType();
       }
   
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           return "";
       }
  
  
  
  1.3       +1 -1      jakarta-ecs/src/java/org/apache/ecs/rtf/Row.java
  
  Index: Row.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/rtf/Row.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- Row.java	2000/01/26 00:13:29	1.2
  +++ Row.java	2001/04/13 14:35:27	1.3
  @@ -92,7 +92,7 @@
       /**
           Create the end element for output.
       */
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer sb = new StringBuffer();
           sb.append("\\row");  // 0 signifies the close of the element.
  
  
  
  1.2       +3 -3      jakarta-ecs/src/java/org/apache/ecs/xhtml/comment.java
  
  Index: comment.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ecs/src/java/org/apache/ecs/xhtml/comment.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- comment.java	2000/11/28 17:35:19	1.1
  +++ comment.java	2001/04/13 14:35:32	1.2
  @@ -65,7 +65,7 @@
   
   /**
       This class defines a comment &lt;-- value --&gt; Element.
  -    @version $Id: comment.java,v 1.1 2000/11/28 17:35:19 jstoor Exp $
  +    @version $Id: comment.java,v 1.2 2001/04/13 14:35:32 snagy Exp $
       @author <a href="mailto:snagy@servletapi.com">Stephan Nagy</a>
       @author <a href="mailto:jon@clearink.com">Jon S. Stevens</a>
       @author <a href="mailto:bojan@binarix.com">Bojan Smojver</a>
  @@ -167,7 +167,7 @@
           return(this);
       }
   
  -    protected String createStartTag()
  +    public String createStartTag()
       {
           setEndTagChar(' ');
           StringBuffer out = new StringBuffer();
  @@ -189,7 +189,7 @@
           return(out.toString());
       }
       
  -    protected String createEndTag()
  +    public String createEndTag()
       {
           StringBuffer out = new StringBuffer();
           setStartTagChar(' ');
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: ecs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: ecs-dev-help@jakarta.apache.org