You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/06/06 07:28:09 UTC
[I] add unit test coverage for FutureBijection and SerializedState [texera]
aglinxinyuan opened a new issue, #5398:
URL: https://github.com/apache/texera/issues/5398
Two small `org.apache.texera.amber.engine.common` helpers used across the engine for cross-runtime / cross-process value conversion. Neither has a unit test today.
Add a single `EngineCommonConversionsSpec` covering:
| File | Behavior to pin |
| --- | --- |
| `FutureBijection.scala` | `RichTwitterFuture.asScala`: a Twitter `Future` completing with `Return(v)` resolves the Scala `Future` with `v`; one completing with `Throw(e)` fails the Scala `Future` with `e`. `RichScalaFuture.asTwitter()`: a Scala `Future.successful(v)` yields a Twitter `Future` returning `v`; a `Future.failed(e)` yields a Twitter `Future` throwing `e`. Implicits resolve from the `import FutureBijection._` site. |
| `SerializedState.scala` | Pin the five `*_KEY` constants (`CP_STATE_KEY`, `DP_STATE_KEY`, `IN_FLIGHT_MSG_KEY`, `DP_QUEUED_MSG_KEY`, `OUTPUT_MSG_KEY`). `fromObject` captures bytes + serializer id + manifest; `toObject` round-trips back to value-equal object via the same `Serialization`. `size()` equals `bytes.length`. |
`SerializedState` requires a real Pekko `Serialization` — the spec owns a suite-local `ActorSystem` and tears it down in `afterAll` (same pattern as `CheckpointSubsystemSpec`).
### Priority
P3 - Low
### Task Type
- [x] Testing / QA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for FutureBijection and SerializedState [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #5398: add unit test coverage for FutureBijection and SerializedState
URL: https://github.com/apache/texera/issues/5398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for FutureBijection and SerializedState [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on issue #5398:
URL: https://github.com/apache/texera/issues/5398#issuecomment-4700114274
Already covered — `FutureBijection` is tested in `FutureBijectionSpec` (PR #5555, merged 2026-06-12) and `SerializedState` is pinned in `CheckpointSubsystemSpec` (PR #4838, merged 2026-05-03, which predates this issue). No untested surface remains — closing as completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org