You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/06/08 01:33:23 UTC
[GitHub] [servicecomb-java-chassis] fanjiang-2021 opened a new pull request #2406: in safe mode , before merge Instances should ping instance
fanjiang-2021 opened a new pull request #2406:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2406: [#2398]in safe mode , before merge Instances should ping instance
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2406:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2406: [#2398]in safe mode , before merge Instances should ping instance
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2406:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2406#issuecomment-856396219
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2406](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2ffd6b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/efbeee2f21c356084b829c84af0afded80612d36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efbeee2) will **increase** coverage by `0.05%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2406 +/- ##
============================================
+ Coverage 79.95% 80.00% +0.05%
Complexity 1408 1408
============================================
Files 1549 1549
Lines 41348 41349 +1
Branches 3444 3445 +1
============================================
+ Hits 33059 33081 +22
+ Misses 6815 6795 -20
+ Partials 1474 1473 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cecomb/registry/consumer/MicroserviceVersions.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvY29uc3VtZXIvTWljcm9zZXJ2aWNlVmVyc2lvbnMuamF2YQ==) | `81.39% <33.33%> (-0.64%)` | :arrow_down: |
| [...mb/serviceregistry/task/MicroserviceWatchTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3Rhc2svTWljcm9zZXJ2aWNlV2F0Y2hUYXNrLmphdmE=) | `70.00% <0.00%> (+1.66%)` | :arrow_up: |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `77.57% <0.00%> (+1.86%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.56% <0.00%> (+2.70%)` | :arrow_up: |
| [...rviceregistry/client/http/WebsocketClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1dlYnNvY2tldENsaWVudFV0aWwuamF2YQ==) | `77.19% <0.00%> (+3.50%)` | :arrow_up: |
| [...cecomb/serviceregistry/task/ServiceCenterTask.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3Rhc2svU2VydmljZUNlbnRlclRhc2suamF2YQ==) | `89.79% <0.00%> (+6.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [efbeee2...f2ffd6b](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2406?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org